|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge |
Date: | Mon, 9 Dec 2019 11:56:49 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 12/9/19 11:42 AM, Paolo Bonzini wrote:
On 09/12/19 11:10, Durrant, Paul wrote:Signed-off-by: Philippe Mathieu-Daudé <address@hidden> --- v3: Only default with Xen (Alex Williamson) I did not used 'depends on XEN' as suggested by Alex but 'default y if XEN', so one can build XEN without this feature (for example, on other ARCH than X86).I think what you want is achieved by default y depends on XEN && PC_I440FX
I think so, but with PC_I440FX -> PCI_I440FX ;)It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH').
This can be another step, so if this series looks OK to you so far, do you mind fixing this and the comment in the previous patch noticed by Thomas:
- Extract it into a new file, 'hw/pci-host/igd_pt.c'. + Extract it into a new file, 'hw/pci-host/xen_igd_pt.c'. Thanks! Phil.
[Prev in Thread] | Current Thread | [Next in Thread] |