Re: [PATCH for-5.0 v11 02/20] virtio-iommu: Add skeleton

[Jean-Philippe Brucker]

Hi Eric,

On Fri, Nov 22, 2019 at 07:29:25PM +0100, Eric Auger wrote:
> +typedef struct VirtIOIOMMU {
> +    VirtIODevice parent_obj;
> +    VirtQueue *req_vq;
> +    VirtQueue *event_vq;
> +    struct virtio_iommu_config config;
> +    uint64_t features;
> +    uint64_t acked_features;

We already have guest_features in the parent object.

> +    GHashTable *as_by_busptr;
> +    IOMMUPciBus *as_by_bus_num[IOMMU_PCI_BUS_MAX];

Doesn't seem used anymore.

Thanks,
Jean

> +    PCIBus *primary_bus;
> +    GTree *domains;
> +    QemuMutex mutex;
> +    GTree *endpoints;
> +} VirtIOIOMMU;
> +
> +#endif
> -- 
> 2.20.1
> 
>