[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-user-test: fix a memory leak
From: |
Thomas Huth |
Subject: |
Re: [PATCH] vhost-user-test: fix a memory leak |
Date: |
Wed, 11 Dec 2019 08:57:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
Hi!
On 11/12/2019 01.55, address@hidden wrote:
[...]
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 91ea373..54be931 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -717,6 +717,8 @@ static void test_migrate(void *obj, void *arg,
> QGuestAllocator *alloc)
> guint64 size;
>
> if (!wait_for_fds(s)) {
> + g_free(uri);
> + test_server_free(dest);
> return;
> }
Well spotted. But I'd prefer to rather move the allocation of these
resources after the if-statement instead of doing the allocation at the
declaration of the variables already. Or maybe use a "goto out" and jump
to the end of the function instead? ... whatever you prefer, but
duplicating the "free" functions sounds like a cumbersome solution to me.
Thanks,
Thomas