[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance |
Date: |
Thu, 12 Dec 2019 16:38:59 +0000 |
From: piaojun <address@hidden>
fuse_buf_writev() only handles the normal write in which src is buffer
and dest is fd. Specially if src buffer represents guest physical
address that can't be mapped by the daemon process, IO must be bounced
back to the VMM to do it by fuse_buf_copy().
Signed-off-by: Jun Piao <address@hidden>
Suggested-by: Dr. David Alan Gilbert <address@hidden>
Suggested-by: Stefan Hajnoczi <address@hidden>
---
tools/virtiofsd/buffer.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/virtiofsd/buffer.c b/tools/virtiofsd/buffer.c
index ae420c70c4..4875473785 100644
--- a/tools/virtiofsd/buffer.c
+++ b/tools/virtiofsd/buffer.c
@@ -33,9 +33,7 @@ size_t fuse_buf_size(const struct fuse_bufvec *bufv)
return size;
}
-__attribute__((unused))
-static ssize_t fuse_buf_writev(fuse_req_t req,
- struct fuse_buf *out_buf,
+static ssize_t fuse_buf_writev(struct fuse_buf *out_buf,
struct fuse_bufvec *in_buf)
{
ssize_t res, i, j;
@@ -334,12 +332,29 @@ static int fuse_bufvec_advance(struct fuse_bufvec *bufv,
size_t len)
ssize_t fuse_buf_copy(struct fuse_bufvec *dstv, struct fuse_bufvec *srcv,
enum fuse_buf_copy_flags flags)
{
- size_t copied = 0;
+ size_t copied = 0, i;
if (dstv == srcv) {
return fuse_buf_size(dstv);
}
+ /*
+ * use writev to improve bandwidth when all the
+ * src buffers already mapped by the daemon
+ * process
+ */
+ for (i = 0; i < srcv->count; i++) {
+ if (srcv->buf[i].flags & FUSE_BUF_IS_FD) {
+ break;
+ }
+ }
+ if ((i == srcv->count) && (dstv->count == 1) &&
+ (dstv->idx == 0) &&
+ (dstv->buf[0].flags & FUSE_BUF_IS_FD)) {
+ dstv->buf[0].pos += dstv->off;
+ return fuse_buf_writev(&dstv->buf[0], srcv);
+ }
+
for (;;) {
const struct fuse_buf *src = fuse_bufvec_current(srcv);
const struct fuse_buf *dst = fuse_bufvec_current(dstv);
--
2.23.0
- [PATCH 090/104] virtiofsd: rename inode->refcount to inode->nlookup, (continued)
- [PATCH 090/104] virtiofsd: rename inode->refcount to inode->nlookup, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 092/104] virtiofsd: add man page, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 094/104] virtiofsd: do not always set FUSE_FLOCK_LOCKS, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 095/104] virtiofsd: convert more fprintf and perror to use fuse log infra, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 093/104] virtiofsd: introduce inode refcount to prevent use-after-free, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 096/104] virtiofsd: Reset O_DIRECT flag during file open, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 097/104] virtiofsd: Fix data corruption with O_APPEND wirte in writeback mode, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 098/104] virtiofsd: add definition of fuse_buf_writev(), Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance,
Dr. David Alan Gilbert (git) <=
- [PATCH 102/104] virtiofsd: fix lo_destroy() resource leaks, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 103/104] virtiofsd: add --thread-pool-size=NUM option, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 101/104] virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 100/104] virtiofsd: process requests in a thread pool, Dr. David Alan Gilbert (git), 2019/12/12
- [PATCH 104/104] virtiofsd: Convert lo_destroy to take the lo->mutex lock itself, Dr. David Alan Gilbert (git), 2019/12/12
- Re: [PATCH 000/104] virtiofs daemon [all], no-reply, 2019/12/12