[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/10] pseries: disable migration-test if /dev/kvm cannot be used
From: |
Thomas Huth |
Subject: |
[PULL 06/10] pseries: disable migration-test if /dev/kvm cannot be used |
Date: |
Thu, 12 Dec 2019 19:54:20 +0100 |
From: Laurent Vivier <address@hidden>
On ppc64, migration-test only works with kvm_hv, and we already
have a check to verify the module is loaded.
kvm_hv module can be loaded in memory and /sys/module/kvm_hv exists,
but on some systems (like build systems) /dev/kvm can be missing
(by administrators choice).
And as kvm_hv exists test-migration is started but QEMU falls back to
TCG because it cannot be used:
Could not access KVM kernel module: No such file or directory
failed to initialize KVM: No such file or directory
Back to tcg accelerator
And as the test is done with TCG, it fails.
As for s390x, we must check for the existence and the access rights
of /dev/kvm.
Reported-by: Cole Robinson <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/migration-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index ebd77a581a..a5343fdc66 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -1349,7 +1349,8 @@ int main(int argc, char **argv)
* some reason)
*/
if (g_str_equal(qtest_get_arch(), "ppc64") &&
- access("/sys/module/kvm_hv", F_OK)) {
+ (access("/sys/module/kvm_hv", F_OK) ||
+ access("/dev/kvm", R_OK | W_OK))) {
g_test_message("Skipping test: kvm_hv not available");
return g_test_run();
}
--
2.18.1
- [PULL 00/10] Bluetooth removal, and qtest & misc patches, Thomas Huth, 2019/12/12
- [PULL 01/10] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev, Thomas Huth, 2019/12/12
- [PULL 02/10] hw/usb: Remove the USB bluetooth dongle device, Thomas Huth, 2019/12/12
- [PULL 04/10] Remove libbluetooth / bluez from the CI tests, Thomas Huth, 2019/12/12
- [PULL 05/10] tests: fix modules-test 'duplicate test case' error, Thomas Huth, 2019/12/12
- [PULL 06/10] pseries: disable migration-test if /dev/kvm cannot be used,
Thomas Huth <=
- [PULL 07/10] hw/misc/ivshmem: Bury dead legacy INTx code, Thomas Huth, 2019/12/12
- [PULL 08/10] glib: use portable g_setenv(), Thomas Huth, 2019/12/12
- [PULL 09/10] tests/Makefile: Fix check-report.* targets shown in check-help, Thomas Huth, 2019/12/12
- [PULL 10/10] tests: use g_test_rand_int, Thomas Huth, 2019/12/12
- [PULL 03/10] Remove the core bluetooth code, Thomas Huth, 2019/12/12
- Re: [PULL 00/10] Bluetooth removal, and qtest & misc patches, Peter Maydell, 2019/12/16