Re: [PATCH 0/3] q800: update machine emulation

[Mark Cave-Ayland]

On 12/12/2019 20:01, Laurent Vivier wrote:

> On the way to run a MacOS ROM we need a more accurate
> emulation of the Quadra 800.
> 
> This series fixes the ESCC base address that was wrong but
> as the linux kernel uses the one provided by the bootloader
> (in our case QEMU) it was not a problem. This value
> is hardcoded in the ROM, so QEMU must use the good one.
> 
> The two other patches update the description of the machine
> by introducing the djMEMC memory controller and the machine id
> register.
> 
> Laurent Vivier (3):
>   q800: fix ESCC base
>   q800: add djMEMC memory controller
>   q800: add machine id register
> 
>  MAINTAINERS              |   2 +
>  hw/m68k/Kconfig          |   1 +
>  hw/m68k/q800.c           |  85 +++++++++----------
>  hw/misc/Kconfig          |   3 +
>  hw/misc/Makefile.objs    |   1 +
>  hw/misc/djmemc.c         | 176 +++++++++++++++++++++++++++++++++++++++
>  hw/misc/trace-events     |   4 +
>  include/hw/misc/djmemc.h |  34 ++++++++
>  8 files changed, 260 insertions(+), 46 deletions(-)
>  create mode 100644 hw/misc/djmemc.c
>  create mode 100644 include/hw/misc/djmemc.h

I think this is mostly there other than a few minor style and other tweaks, 
however
I'm wondering that since the q800 seems to have a few esoteric devices if it is 
worth
creating a separate subdirectory for them all under hw/misc/mac or similar?


ATB,

Mark.