[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 8/8] target/i386/cpu: Use 'mr' for MemoryRegion variables
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 8/8] target/i386/cpu: Use 'mr' for MemoryRegion variables |
Date: |
Sat, 14 Dec 2019 16:56:14 +0100 |
The codebase use 'as' in variable names for AddressSpace objects,
and 'mr' for MemoryRegion objects. Since these variables are
MemoryRegion objects, rename them as 'mr' to avoid confusion with
AddressSpace objects.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
target/i386/cpu.h | 2 +-
target/i386/cpu.c | 18 +++++++++---------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index cde2a16b94..1e5ded6e84 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1713,7 +1713,7 @@ struct X86CPU {
/* in order to simplify APIC support, we leave this pointer to the
user */
struct DeviceState *apic_state;
- struct MemoryRegion *cpu_as_root, *cpu_as_mem, *smram;
+ MemoryRegion *cpu_mr_root, *cpu_mr_mem, *smram;
Notifier machine_done;
struct kvm_msrs *kvm_msr_buf;
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 6131c62f9d..b5d22740b8 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5983,7 +5983,7 @@ static void x86_cpu_machine_done(Notifier *n, void
*unused)
memory_region_init_alias(cpu->smram, OBJECT(cpu), "smram",
smram, 0, 1ull << 32);
memory_region_set_enabled(cpu->smram, true);
- memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->smram,
1);
+ memory_region_add_subregion_overlap(cpu->cpu_mr_root, 0, cpu->smram,
1);
}
}
#else
@@ -6471,24 +6471,24 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
#ifndef CONFIG_USER_ONLY
if (tcg_enabled()) {
- cpu->cpu_as_mem = g_new(MemoryRegion, 1);
- cpu->cpu_as_root = g_new(MemoryRegion, 1);
+ cpu->cpu_mr_mem = g_new(MemoryRegion, 1);
+ cpu->cpu_mr_root = g_new(MemoryRegion, 1);
/* Outer container... */
- memory_region_init(cpu->cpu_as_root, OBJECT(cpu), "memory", ~0ull);
- memory_region_set_enabled(cpu->cpu_as_root, true);
+ memory_region_init(cpu->cpu_mr_root, OBJECT(cpu), "memory", ~0ull);
+ memory_region_set_enabled(cpu->cpu_mr_root, true);
/* ... with two regions inside: normal system memory with low
* priority, and...
*/
- memory_region_init_alias(cpu->cpu_as_mem, OBJECT(cpu), "memory",
+ memory_region_init_alias(cpu->cpu_mr_mem, OBJECT(cpu), "memory",
get_system_memory(), 0, ~0ull);
- memory_region_add_subregion(cpu->cpu_as_root, 0, cpu->cpu_as_mem);
- memory_region_set_enabled(cpu->cpu_as_mem, true);
+ memory_region_add_subregion(cpu->cpu_mr_root, 0, cpu->cpu_mr_mem);
+ memory_region_set_enabled(cpu->cpu_mr_mem, true);
cs->num_ases = 2;
cpu_address_space_init(cs, 0, "cpu-memory", cs->memory);
- cpu_address_space_init(cs, 1, "cpu-smm", cpu->cpu_as_root);
+ cpu_address_space_init(cs, 1, "cpu-smm", cpu->cpu_mr_root);
/* ... SMRAM with higher priority, linked from /machine/smram. */
cpu->machine_done.notify = x86_cpu_machine_done;
--
2.21.0
- [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 8/8] target/i386/cpu: Use 'mr' for MemoryRegion variables,
Philippe Mathieu-Daudé <=
- [PATCH 1/8] hw/arm/nrf51_soc: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 3/8] hw/arm/xlnx-versal: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 2/8] hw/arm/raspi: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 6/8] hw/vfio/pci: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 5/8] hw/mips/boston: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 7/8] target/i386: Use memory_region_add_subregion() when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- [PATCH 4/8] hw/i386/intel_iommu: Use memory_region_add_subregion when priority is 0, Philippe Mathieu-Daudé, 2019/12/14
- Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0), Peter Maydell, 2019/12/14