qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/10] arm: allwinner-h3: add System Control module


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 05/10] arm: allwinner-h3: add System Control module
Date: Mon, 16 Dec 2019 01:17:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/16/19 12:27 AM, Niek Linnenbank wrote:
On Fri, Dec 13, 2019 at 1:09 AM Philippe Mathieu-Daudé <address@hidden <mailto:address@hidden>> wrote:

    On 12/2/19 10:09 PM, Niek Linnenbank wrote:
[...]
     > +static const MemoryRegionOps allwinner_h3_syscon_ops = {
     > +    .read = allwinner_h3_syscon_read,
     > +    .write = allwinner_h3_syscon_write,
     > +    .endianness = DEVICE_NATIVE_ENDIAN,
     > +    .valid = {
     > +        .min_access_size = 4,
     > +        .max_access_size = 4,

    Can you point me to the datasheet page that says this region is
    restricted to 32-bit accesses? Maybe you want .valid -> .impl instead?

Hehe well here I can only give the same answer as for the SD/MMC driver: the datasheet only provides the base address and register offsets, but nothing explicitely mentioned about alignment.
I do see that also for this device the registers are 32-bit aligned.

Does that mean I should change MemoryRegionOps to . impl instead?

No, keep them, but add ".impl.min_access_size = 4" (see answer to SD/MMC model patch).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]