[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug 1856549] Re: qemu-4.2.0/hw/misc/mac_via.c: 2 * bad test ?
From: |
dcb |
Subject: |
[Bug 1856549] Re: qemu-4.2.0/hw/misc/mac_via.c: 2 * bad test ? |
Date: |
Mon, 16 Dec 2019 11:58:44 -0000 |
gcc compiler flag -Wduplicated-cond will catch this kind of problem.
You might want to switch it on in your builds. It has been available for
over a year.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856549
Title:
qemu-4.2.0/hw/misc/mac_via.c: 2 * bad test ?
Status in QEMU:
New
Bug description:
1.
qemu-4.2.0/hw/misc/mac_via.c:417:27: style: Expression is always false
because 'else if' condition matches previous condition at line 412.
[multiCondition]
} else if ((m->data_out & 0xf3) == 0xa1) {
...
} else if ((m->data_out & 0xf3) == 0xa1) {
2.
qemu-4.2.0/hw/misc/mac_via.c:467:27: style: Expression is always false
because 'else if' condition matches previous condition at line 463.
[multiCondition]
Duplicate.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1856549/+subscriptions