Re: [PATCH v3 00/22] iotests: Allow ./check -o data_file

[Max Reitz]

On 07.11.19 17:36, Max Reitz wrote:
> Hi,
> 
> The cover letter from v1 (explaining the motivation behind this series
> and the general structure) is here:
> 
> https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html
> 
> 
> For v2, I’ve addressed more of Maxim’s comments:
> - Patch 1: Added; Maxim noted this problem on patch 5, but that patch
>            doesn’t touch all files that have this mistake, so I decided
>            to make it an extra patch
> 
> - Patch 20 (now patch 21):
>   - Added TODO comments where it would make sense to at some point split
>     off some cases into an own test file (so they can run with an
>     external data file, where the whole test now has to be skipped)
>   - Fixed the reason why we have to skip 138 with external data files
>   - Disable 261, too (which was added in the meantime)
> 
> - Some contextual differences in some patches due to the $SOCK_DIR
>   series

Thanks for the reviews, fixed the typo in patch 21, disabled data_file
for 273 (which was added in the meantime), and applied the series to my
block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max

signature.asc
Description: OpenPGP digital signature