Re: [PATCH v6 4/4] hw/arm: Add the Netduino Plus 2

[Peter Maydell]

On Sat, 14 Dec 2019 at 02:44, Alistair Francis <address@hidden> wrote:
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>  MAINTAINERS            |  6 +++++
>  hw/arm/Kconfig         |  3 +++
>  hw/arm/Makefile.objs   |  1 +
>  hw/arm/netduinoplus2.c | 52 ++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 62 insertions(+)
>  create mode 100644 hw/arm/netduinoplus2.c
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 7bfdc3a7ac..881e7f56e7 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -105,6 +105,9 @@ config NETDUINOPLUS2
>      bool
>      select STM32F405_SOC
>
> +config NETDUINOPLUS2
> +    bool
> +
>  config NSERIES
>      bool
>      select OMAP

Something odd has happened here -- your patch 1/4 already
had a stanza:

+config NETDUINOPLUS2
+    bool
+    select STM32F405_SOC

so either that should be in this patch or this fragment here
should just be deleted.

Assuming you sort that out,
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM