[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings |
|
Date: |
Wed, 18 Dec 2019 07:05:03 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
"Chubb, Peter (Data61, Kensington NSW)" <address@hidden>
writes:
>>>>>> "Philippe" == Philippe Mathieu-Daudé <address@hidden> writes:
>
> Philippe> Fix some trivial warnings when building with -O3.
>
> For compatibility with lint and other older checkers, it'd be good to keep
> this as /* FALLTHROUGH */ (which gcc should accept according to its
> manual).
We have hundreds of /* fall through */ comments already.
> Fixing the comments' placement is a different matter, and should be
> done. Seems to me that until gcc started warning for this, noone had
> actually run a checker, and the comments were just for human info.
>
> Peter C