[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] blockjob: Fix error message for negative speed
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH v2] blockjob: Fix error message for negative speed |
|
Date: |
Wed, 18 Dec 2019 11:16:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 17.12.19 16:04, Kevin Wolf wrote:
> The error message for a negative speed uses QERR_INVALID_PARAMETER,
> which implies that the 'speed' option doesn't even exist:
>
> {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}}
>
> Make it use QERR_INVALID_PARAMETER_VALUE instead:
>
> {"error": {"class": "GenericError", "desc": "Parameter 'speed' expects a
> non-negative value"}}
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
>
> v2:
> - Update reference output for 030 [Max]
>
> blockjob.c | 3 ++-
> tests/qemu-iotests/030 | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature