[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] qcow2: Move error check of local_err near its assignment
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2] qcow2: Move error check of local_err near its assignment |
Date: |
Thu, 19 Dec 2019 14:32:37 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 18.12.2019 um 12:53 hat Tuguoyi geschrieben:
> The local_err check outside of the if block was necessary
> when it was introduced in commit d1258dd0c87 because it needed to be
> executed even if qcow2_load_autoloading_dirty_bitmaps() returned false.
>
> After some modifications that all required the error check to remain
> where it is, commit 9c98f145dfb finally moved the
> qcow2_load_dirty_bitmaps() call into the if block, so now the error
> check should be there, too.
>
> Signed-off-by: Guoyi Tu <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Thanks, applied to the block branch.
Kevin