[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 06/21] target/arm: use gdb_get_reg helpers
From: |
Alex Bennée |
Subject: |
[PATCH v4 06/21] target/arm: use gdb_get_reg helpers |
Date: |
Fri, 20 Dec 2019 12:04:23 +0000 |
This is cleaner than poking memory directly and will make later
clean-ups easier.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
v2
- make sure we pass hi/lo correctly as quads are stored in LE order
---
target/arm/helper.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 5074b5f69ca..6f3b6ca7d3f 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -105,21 +105,17 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env,
uint8_t *buf, int reg)
{
switch (reg) {
case 0 ... 31:
- /* 128 bit FP register */
- {
- uint64_t *q = aa64_vfp_qreg(env, reg);
- stq_le_p(buf, q[0]);
- stq_le_p(buf + 8, q[1]);
- return 16;
- }
+ {
+ /* 128 bit FP register - quads are in LE order */
+ uint64_t *q = aa64_vfp_qreg(env, reg);
+ return gdb_get_reg128(buf, q[1], q[0]);
+ }
case 32:
/* FPSR */
- stl_p(buf, vfp_get_fpsr(env));
- return 4;
+ return gdb_get_reg32(buf, vfp_get_fpsr(env));
case 33:
/* FPCR */
- stl_p(buf, vfp_get_fpcr(env));
- return 4;
+ return gdb_get_reg32(buf,vfp_get_fpcr(env));
default:
return 0;
}
--
2.20.1
- [PATCH v4 00/21] gdbstub refactor and SVE support (+check-tcg tweaks), Alex Bennée, 2019/12/20
- [PATCH v4 01/21] gdbstub: make GDBState static and have common init function, Alex Bennée, 2019/12/20
- [PATCH v4 05/21] gdbstub: add helper for 128 bit registers, Alex Bennée, 2019/12/20
- [PATCH v4 03/21] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2019/12/20
- [PATCH v4 04/21] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2019/12/20
- [PATCH v4 06/21] target/arm: use gdb_get_reg helpers,
Alex Bennée <=
- [PATCH v4 02/21] gdbstub: stop passing GDBState * around and use global, Alex Bennée, 2019/12/20
- [PATCH v4 07/21] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2019/12/20
- [PATCH v4 10/21] target/arm: explicitly encode regnum in our XML, Alex Bennée, 2019/12/20
- [PATCH v4 09/21] target/arm: prepare for multiple dynamic XMLs, Alex Bennée, 2019/12/20
- [PATCH v4 17/21] tests/tcg/aarch64: add a gdbstub testcase for SVE registers, Alex Bennée, 2019/12/20
- [PATCH v4 16/21] tests/guest-debug: add a simple test runner, Alex Bennée, 2019/12/20
- [PATCH v4 08/21] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2019/12/20
- [PATCH v4 18/21] tests/tcg/aarch64: add SVE iotcl test, Alex Bennée, 2019/12/20
- [PATCH v4 11/21] target/arm: default SVE length to 64 bytes for linux-user, Alex Bennée, 2019/12/20