Re: [PULL 0/6] QAPI patches for 2019-12-17

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On Wed, 18 Dec 2019 at 08:42, Markus Armbruster <address@hidden> wrote:
>> Perplexing.  None of the files involved gets changed by this pull
>> request.  My qapi-types-crypto.h has
>>
>>     typedef struct QCryptoBlockOptionsQCow QCryptoBlockOptionsQCow;
>>     [...]
>>     struct QCryptoBlockOptionsQCow {
>>         bool has_key_secret;
>>         char *key_secret;
>>     };
>>     [...]
>>     struct QCryptoBlockOpenOptions {
>>         /* Members inherited from QCryptoBlockOptionsBase: */
>>         QCryptoBlockFormat format;
>>         /* Own members: */
>>         union { /* union tag is @format */
>>             QCryptoBlockOptionsQCow qcow;
>>             QCryptoBlockOptionsLUKS luks;
>>         } u;
>>     };
>>
>> before and after.  May I see yours?
>
> Unfortunately not -- I've already discarded this build attempt
> and continued with processing other merge requests.

Alright, I closed the curtains, lighted some incense sticks, stared deep
into the crystal ball, and beheld the number two.  Two as in Python 2.

Are we ready to ditch Python 2 in 5.0?