Re: [PATCH] block/rbd: Add support for ceph namespaces

[Eric Blake]

On 12/20/19 11:17 AM, Florian Florensa wrote:

> > > > The patch LGTM, but I'd like to use 'namespace' instead of cryptic
> > > > 'nspace'. (as BlockdevOptionsNVMe did)
> > > > What do you think?
> > > Yes no worries, I can rename it to 'rbd_namespace' to avoid any possible
> > > confusion, is this Ok for you ?
> >
> > We use "pool_namespace" in the rbd CLI if you are trying to avoid the
> > word "namespace".
> Yes I wanted to avoid namespace because it looks like the qapi generated
> code changes the name to something like q_namespace, will use
> pool_namespace in the v2.

The whole point of the mangling of 'q_namespace' in the C code is so 
that you can have a SANE name in the qapi, without tripping up 
compilation in a C++ compiler where 'namespace' is a reserved word 
(since we do have parts of qemu compiled by c++).  I'd go with just 
'namespace', rather than 'pool-namespace' (note that if you DO go with a 
longer name, we prefer - over _ in qapi names).

> > > > With those fixed:
> > > >
> > > > Reviewed-by: Stefano Garzarella <address@hidden>

But see my other comment upthread about making the new parameter 
optional, to avoid breaks with older qapi clients.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org