Re: [PATCH v27 06/21] target/rx: CPU definition

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v27 06/21] target/rx: CPU definition

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v27 06/21] target/rx: CPU definition
Date:	Sat, 21 Dec 2019 17:55:06 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/21/19 5:03 PM, Aleksandar Markovic wrote:

On Saturday, December 21, 2019, Yoshinori Sato<address@hidden <mailto:address@hidden>> wrote:
    Signed-off-by: Yoshinori Sato <address@hidden
    <mailto:address@hidden>>

    Message-Id: <address@hidden
    <mailto:address@hidden>>
    Reviewed-by: Richard Henderson <address@hidden
    <mailto:address@hidden>>
    Message-Id: <address@hidden
    <mailto:address@hidden>>


Hi, Yoshinori,

I noticed you have a lot of line like this
Message-Id: <address@hidden<mailto:address@hidden>>
... sometimes even several in the same message.
May I ask you to delete *all* such lines from commit messages, andresend the series?

I expected this series to be ready for merge, and asked Richard if hecould do that to avoid a respin of new version, but apparently Yoshinorimissed my comment:

https://www.mail-archive.com/address@hidden/msg664071.html

Also, I don't see the documentation update for the new target. Pleaseprovide dome appropriate content in qemu-doc.texi (https://github.com/qemu/qemu/blob/master/qemu-doc.texi ), and include itin the next version.
Best regards,

Aleksandar

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v27 03/21] hw/registerfields.h: Add 8bit and 16bit register macros, (continued)
- [PATCH v27 03/21] hw/registerfields.h: Add 8bit and 16bit register macros, Yoshinori Sato, 2019/12/21
- [PATCH v27 08/21] target/rx: Disassemble rx_index_addr into a string, Yoshinori Sato, 2019/12/21
- [PATCH v27 12/21] target/rx: Collect all bytes during disassembly, Yoshinori Sato, 2019/12/21
- [PATCH v27 18/21] hw/rx: Honor -accel qtest, Yoshinori Sato, 2019/12/21
- [PATCH v27 10/21] target/rx: Use prt_ldmi for XCHG_mr disassembly, Yoshinori Sato, 2019/12/21
- [PATCH v27 13/21] target/rx: Dump bytes for each insn during disassembly, Yoshinori Sato, 2019/12/21
- [PATCH v27 09/21] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2019/12/21
- [PATCH v27 20/21] Add rx-softmmu, Yoshinori Sato, 2019/12/21
- [PATCH v27 06/21] target/rx: CPU definition, Yoshinori Sato, 2019/12/21
  - Re: [PATCH v27 06/21] target/rx: CPU definition, Aleksandar Markovic, 2019/12/21
    - Re: [PATCH v27 06/21] target/rx: CPU definition, Philippe Mathieu-Daudé <=
    - Re: [PATCH v27 06/21] target/rx: CPU definition, Yoshinori Sato, 2019/12/22
- [PATCH v27 14/21] hw/intc: RX62N interrupt controller (ICUa), Yoshinori Sato, 2019/12/21
- [PATCH v27 17/21] hw/rx: RX Target hardware definition, Yoshinori Sato, 2019/12/21
  - Re: [PATCH v27 17/21] hw/rx: RX Target hardware definition, Aleksandar Markovic, 2019/12/26
- [PATCH v27 05/21] target/rx: TCG helper, Yoshinori Sato, 2019/12/21
- [PATCH v27 21/21] BootLinuxConsoleTest: Test the RX-Virt machine, Yoshinori Sato, 2019/12/21
- [PATCH v27 07/21] target/rx: RX disassembler, Yoshinori Sato, 2019/12/21
- [PATCH v27 15/21] hw/timer: RX62N internal timer modules, Yoshinori Sato, 2019/12/21
- [PATCH v27 19/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core, Yoshinori Sato, 2019/12/21
- [PATCH v27 16/21] hw/char: RX62N serial communication interface (SCI), Yoshinori Sato, 2019/12/21

Prev by Date: [PATCH] MAINTAINERS: Orphan MIPS KVM CPUs
Next by Date: Re: [PATCH v39 03/22] target/avr: Add instruction decoding
Previous by thread: Re: [PATCH v27 06/21] target/rx: CPU definition
Next by thread: Re: [PATCH v27 06/21] target/rx: CPU definition
Index(es):
- Date
- Thread