[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 48/87] x86: move SMM property to X86MachineState
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PULL 48/87] x86: move SMM property to X86MachineState |
|
Date: |
Mon, 23 Dec 2019 14:38:47 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 23/12/19 12:40, Michal Prívozník wrote:
>
> diff --git i/target/i386/kvm.c w/target/i386/kvm.c
> index 0b511906e3..7ee3202634 100644
> --- i/target/i386/kvm.c
> +++ w/target/i386/kvm.c
> @@ -2173,6 +2173,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
> }
>
> if (kvm_check_extension(s, KVM_CAP_X86_SMM) &&
> + object_dynamic_cast(OBJECT(ms), TYPE_X86_MACHINE) &&
> x86_machine_is_smm_enabled(X86_MACHINE(ms))) {
> smram_machine_done.notify = register_smram_listener;
> qemu_add_machine_init_done_notifier(&smram_machine_done);
Yes, it's correct. Is it okay if I just send a patch with your
Signed-off-by?
Paolo
- [PULL 29/87] kvm: convert "-machine kernel_irqchip" to an accelerator property, (continued)
- [PULL 29/87] kvm: convert "-machine kernel_irqchip" to an accelerator property, Paolo Bonzini, 2019/12/18
- [PULL 40/87] crypto: move common bits for all emulators to libqemuutil, Paolo Bonzini, 2019/12/18
- [PULL 44/87] i386: conditionally compile more files, Paolo Bonzini, 2019/12/18
- [PULL 42/87] configure: set $PYTHON to a full path, Paolo Bonzini, 2019/12/18
- [PULL 45/87] fw_cfg: allow building without other devices, Paolo Bonzini, 2019/12/18
- [PULL 47/87] pci-stub: add more MSI functions, Paolo Bonzini, 2019/12/18
- [PULL 48/87] x86: move SMM property to X86MachineState, Paolo Bonzini, 2019/12/18
[PULL 46/87] hw: replace hw/i386/pc.h with a header just for the i8259, Paolo Bonzini, 2019/12/18
[PULL 49/87] hw/i386/pc: Convert DPRINTF() to trace events, Paolo Bonzini, 2019/12/18
[PULL 50/87] x86: move more x86-generic functions out of PC files, Paolo Bonzini, 2019/12/18
[PULL 51/87] acpi: move PC stubs out of stubs/, Paolo Bonzini, 2019/12/18
[PULL 52/87] pc: stubify x86 iommu, Paolo Bonzini, 2019/12/18
[PULL 53/87] hw/i386: De-duplicate gsi_handler() to remove kvm_pc_gsi_handler(), Paolo Bonzini, 2019/12/18
[PULL 55/87] hw/isa/isa-bus: cleanup irq functions, Paolo Bonzini, 2019/12/18
[PULL 54/87] hw/i386: Simplify ioapic_init_gsi(), Paolo Bonzini, 2019/12/18
[PULL 57/87] hw/i386/pc: Inline port92_init(), Paolo Bonzini, 2019/12/18