Re: [PATCH 1/5] linux-user: Fix some constants in termbits.h

[Max Filippov]

On Mon, Dec 23, 2019 at 6:45 PM Aleksandar Markovic
<address@hidden> wrote:
>
> From: Aleksandar Markovic <address@hidden>
>
> Some constants were defined in terms of host, instead of target,
> as they should be.
>
> Some additional trivial changes in this patch were forced by
> checkpatch.pl.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
[...]
> index d1e09e6..b1853f0 100644
> --- a/linux-user/xtensa/termbits.h
> +++ b/linux-user/xtensa/termbits.h
[...]
> @@ -286,43 +286,61 @@ struct target_ktermios {
[...]
> -#define TARGET_TIOCMIWAIT  _IO('T', 92) /* wait for a change on serial input 
> line(s) */
> -#define TARGET_TIOCGICOUNT 0x545D  /* read serial port inline interrupt 
> counts */
> +/* wait for a change on serial input line(s) */
> +#define TARGET_TIOCMIWAIT  _IO('T', 92)

This one should also be TARGET_IO, right?

> +/* read serial port inline interrupt counts */
> +#define TARGET_TIOCGICOUNT 0x545D
>  #endif /* XTENSA_TERMBITS_H */

Reviewed-by: Max Filippov <address@hidden>

-- 
Thanks.
-- Max