[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/29] target/xtensa: Use probe_access for itlb_hit_test
From: |
Richard Henderson |
Subject: |
[PATCH v3 01/29] target/xtensa: Use probe_access for itlb_hit_test |
Date: |
Sun, 29 Dec 2019 10:10:56 +1100 |
We don't actually need the result of the read, only to probe that the
memory mapping exists. This is exactly what probe_access does.
This is also the only user of any cpu_ld*_code_ra function.
Removing this allows the interface to be removed shortly.
Acked-by: Max Filippov <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/xtensa/mmu_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c
index f15bff306f..b01ff9399a 100644
--- a/target/xtensa/mmu_helper.c
+++ b/target/xtensa/mmu_helper.c
@@ -63,10 +63,11 @@
void HELPER(itlb_hit_test)(CPUXtensaState *env, uint32_t vaddr)
{
/*
- * Attempt the memory load; we don't care about the result but
+ * Probe the memory; we don't care about the result but
* only the side-effects (ie any MMU or other exception)
*/
- cpu_ldub_code_ra(env, vaddr, GETPC());
+ probe_access(env, vaddr, 1, MMU_INST_FETCH,
+ cpu_mmu_index(env, true), GETPC());
}
void HELPER(wsr_rasid)(CPUXtensaState *env, uint32_t v)
--
2.20.1
- [PATCH v3 00/29] cputlb: Remove support for MMU_MODE*_SUFFIX, Richard Henderson, 2019/12/28
- [PATCH v3 01/29] target/xtensa: Use probe_access for itlb_hit_test,
Richard Henderson <=
- [PATCH v3 02/29] cputlb: Use trace_mem_get_info instead of trace_mem_build_info, Richard Henderson, 2019/12/28
- [PATCH v3 03/29] trace: Remove trace_mem_build_info_no_se_[bl]e, Richard Henderson, 2019/12/28
- [PATCH v3 04/29] target/s390x: Include tcg.h in mem_helper.c, Richard Henderson, 2019/12/28
- [PATCH v3 05/29] target/arm: Include tcg.h in sve_helper.c, Richard Henderson, 2019/12/28
- [PATCH v3 06/29] accel/tcg: Include tcg.h in tcg-runtime.c, Richard Henderson, 2019/12/28
- [PATCH v3 07/29] linux-user: Include tcg.h in syscall.c, Richard Henderson, 2019/12/28
- [PATCH v3 08/29] linux-user: Include trace-root.h in syscall-trace.h, Richard Henderson, 2019/12/28
- [PATCH v3 09/29] plugins: Include trace/mem.h in api.c, Richard Henderson, 2019/12/28