Re: [PATCH v2 3/5] semihosting: add qemu_semihosting_console_inc for SYS_READC

[Richard Henderson]

On 12/21/19 12:22 AM, Alex Bennée wrote:
> From: Keith Packard <address@hidden>
> 
> Provides a blocking call to read a character from the console using
> semihosting.chardev, if specified. This takes some careful command
> line options to use stdio successfully as the serial ports, monitor
> and semihost all want to use stdio. Here's a sample set of command
> line options which share stdio between semihost, monitor and serial
> ports:
> 
>       qemu \
>       -chardev stdio,mux=on,id=stdio0 \
>       -serial chardev:stdio0 \
>       -semihosting-config enable=on,chardev=stdio0 \
>       -mon chardev=stdio0,mode=readline
> 
> This creates a chardev hooked to stdio and then connects all of the
> subsystems to it. A shorter mechanism would be good to hear about.
> 
> Signed-off-by: Keith Packard <address@hidden>
> Message-Id: <address@hidden>
> [AJB: fixed up deadlock, minor commit title reword]
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Reviewed-by: Keith Packard <address@hidden>
> Tested-by: Keith Packard <address@hidden>

Reviewed-by: Richard Henderson <address@hidden>


r~