[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config |
|
Date: |
Tue, 31 Dec 2019 19:32:05 +0100 |
When configured with --without-default-devices, the build fails:
LINK x86_64-softmmu/qemu-system-x86_64
/usr/bin/ld: hw/i386/microvm.o: in function `microvm_devices_init':
hw/i386/microvm.c:157: undefined reference to `serial_hds_isa_init'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:206: qemu-system-x86_64] Error 1
make: *** [Makefile:483: x86_64-softmmu/all] Error 2
While the MicroVM machine only uses the ISA serial port when the
MICROVM_MACHINE_ISA_SERIAL property is set, it has to be linked
with it. Replace the 'imply' Kconfig rule by a 'select'.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
Cc: Sergio Lopez <address@hidden>
---
hw/i386/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index e428322a2c..cbcfb1ce81 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -96,7 +96,7 @@ config Q35
config MICROVM
bool
- imply SERIAL_ISA
+ select SERIAL_ISA
select ISA_BUS
select APIC
select IOAPIC
--
2.21.0
- [PATCH 00/14] hw: Fix various --without-default-devices issues, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 01/14] hw/usb/redirect: Do not link 'usb-redir' device when USB not enabled, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 02/14] hw/intc/i8259: Fix Kconfig dependency on ISA bus, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config,
Philippe Mathieu-Daudé <=
- [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 05/14] hw/i2c/Kconfig: Add an entry for the SMBus, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 06/14] hw/ppc/Kconfig: Restrict the MPC I2C controller to e500-based platforms, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 07/14] hw/ppc/Kconfig: Let the Sam460ex board use the PowerPC 405 devices, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 08/14] hw/ppc/Kconfig: Let the Xilinx Virtex5 ML507 use the PPC-440 devices, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 09/14] hw/ppc/Makefile: Simplify the sPAPR PCI objects rule, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 10/14] hw/ppc/Kconfig: Only select fw_cfg with machines using OpenBIOS, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 11/14] hw/ppc/Kconfig: Only select FDT helper for machines using it, Philippe Mathieu-Daudé, 2019/12/31
- [PATCH 13/14] hw/nvram/Kconfig: Restrict CHRP NVRAM to machines using OpenBIOS or SLOF, Philippe Mathieu-Daudé, 2019/12/31