[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typed
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v2 0/3] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typedefs |
Date: |
Thu, 4 Jun 2020 20:57:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 01/06/20 16:15, Philippe Mathieu-Daudé wrote:
> Followed Peter's suggestions [1]:
>
> * delete the unused MmeoryRegionMmio
> * move these typedefs into include/hw/usb.h and rename them
> to MUSBReadFunc and MUSBWriteFunc, since that's all they're
> used for now
>
> Since v1 [2], addressed Peter review:
> - Renamed include/hw/usb/musb.h -> include/hw/usb/hcd-musb.h
> - Added Peter's R-b tags
>
> Series fully reviewed.
>
> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708165.html
> [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708194.html
>
> Philippe Mathieu-Daudé (3):
> exec/memory: Remove unused MemoryRegionMmio type
> hw/usb: Move device-specific declarations to new 'hcd-musb.h' header
> exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h'
>
> include/exec/cpu-common.h | 3 ---
> include/exec/memory.h | 6 -----
> include/hw/usb.h | 30 -------------------------
> include/hw/usb/hcd-musb.h | 47 +++++++++++++++++++++++++++++++++++++++
> hw/usb/hcd-musb.c | 5 +++--
> hw/usb/tusb6010.c | 1 +
> 6 files changed, 51 insertions(+), 41 deletions(-)
> create mode 100644 include/hw/usb/hcd-musb.h
>
Queued, thanks.
Paolo