Re: [PATCH 1/2] Introduce (x86) CPU model deprecation API

[Robert Hoo]

On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote:
> On 6/4/20 3:07 AM, Robert Hoo wrote:
> 
> > > > +++ b/qapi/machine-target.json
> > > > @@ -309,7 +309,8 @@
> > > >                'static': 'bool',
> > > >                '*unavailable-features': [ 'str' ],
> > > >                'typename': 'str',
> > > > -            '*alias-of' : 'str' },
> > > > +            '*alias-of' : 'str',
> > > > +            'deprecated' : 'bool' },
> > > 
> > > Missing documentation of the new member.  Should it be optional
> > > (present
> > > only when true)?
> > 
> > Which document do you mean?

Thanks Eric:)

> 
> A few lines earlier is '@alias-of: ...'; you'll need to add a
> similar 
> line for '@deprecated', mentioning it is '(since 5.1)'.
> 
> > How to make it optional?

How about not making it optional? refer to Machineinfo::deprecated.
> 
> Name it '*deprecated', then deal with 'has_deprecated' in the C code
> for 
> the cases where the member should be output.
>