qemu-devel
[
Top
][
All Lists
]
Advanced
[
Date Prev
][
Date Next
][
Thread Prev
][
Thread Next
][
Date Index
][
Thread Index
]
Re: [PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a sub
From
:
Andrey Shinkevich
Subject
:
Re: [PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct
Date
:
Fri, 5 Jun 2020 15:30:32 +0000
I'd add a comment that correct current file offset is the responsibility of a caller.
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
From:
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Sent:
Thursday, June 4, 2020 8:41 PM
To:
qemu-block@nongnu.org <qemu-block@nongnu.org>
Cc:
qemu-devel@nongnu.org <qemu-devel@nongnu.org>; mreitz@redhat.com <mreitz@redhat.com>; kwolf@redhat.com <kwolf@redhat.com>; eblake@redhat.com <eblake@redhat.com>; Denis Lunev <den@virtuozzo.com>; Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>; Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Subject:
[PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct
Only two fields we can parse by generic code, but that is better than
nothing. Keep further refactoring of variable-length fields for another
day.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/qcow2_format.py | 51 ++++++++++++++++++++----------
1 file changed, 35 insertions(+), 16 deletions(-)
reply via email to
[
Prev in Thread
]
Current Thread
[
Next in Thread
]
Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields
,
(continued)
Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields
,
Andrey Shinkevich
,
2020/06/05
Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields
,
Eric Blake
,
2020/06/05
[PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes
,
Andrey Shinkevich
,
2020/06/05
Re: [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes
,
Vladimir Sementsov-Ogievskiy
,
2020/06/05
[PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump()
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump()
,
Andrey Shinkevich
,
2020/06/05
[PATCH v4 05/12] qcow2_format.py: use modern string formatting
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 05/12] qcow2_format.py: use modern string formatting
,
Andrey Shinkevich
,
2020/06/05
[PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct
,
Andrey Shinkevich
<=
[PATCH v4 08/12] qcow2_format.py: add field-formatting class
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 08/12] qcow2_format.py: add field-formatting class
,
Andrey Shinkevich
,
2020/06/05
[PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
,
Andrey Shinkevich
,
2020/06/05
Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
,
Eric Blake
,
2020/06/05
Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
,
Vladimir Sementsov-Ogievskiy
,
2020/06/06
[PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics
,
Vladimir Sementsov-Ogievskiy
,
2020/06/04
Re: [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics
,
Andrey Shinkevich
,
2020/06/05
Re: [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics
,
Vladimir Sementsov-Ogievskiy
,
2020/06/05
Re: [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics
,
Andrey Shinkevich
,
2020/06/05
Prev by Date:
Re: [PATCH 05/16] fdc: Open-code fdctrl_init_isa()
Next by Date:
Re: [PATCH v2 0/7] exec/cpu: Cleanups around "exec/hwaddr.h" (reserved to system-mode)
Previous by thread:
[PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct
Next by thread:
[PATCH v4 08/12] qcow2_format.py: add field-formatting class
Index(es):
Date
Thread