|
From: | Eric Blake |
Subject: | Re: [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata |
Date: | Fri, 5 Jun 2020 15:50:14 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
Hi all! Here is my suggestion to substitute only first three patches :) of Andrey's [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata so, I called it v4 for convenience. What is here: 1. First, update code style 2. Next, try to refactor in a manner which will make adding new data structures simple (look at Qcow2BitmapExt class in last patch) I think, next step is to add type hints. Then add more structures. And, anyway, at some point we should move it into python/ directory (at least qcow2_format.py lib)
My python reviewing skills are weak, but in general this series makes sense. I had enough comments that you're probably better off spinning a v5, but it looks like it is probably close enough that I can include this in my next bitmaps pull request, and we can work on rebasing the remainder of Andrey's patches on top of it.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |