Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module

[Vladimir Sementsov-Ogievskiy]

05.06.2020 23:14, Eric Blake wrote:
> On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
> > We are going to enhance qcow2 format parsing by adding more structure
> > classes. Let's split format parsing from utility code.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   tests/qemu-iotests/qcow2.py        | 161 +----------------------------
> >   tests/qemu-iotests/qcow2_format.py | 157 ++++++++++++++++++++++++++++
> >   2 files changed, 161 insertions(+), 157 deletions(-)
> >   create mode 100644 tests/qemu-iotests/qcow2_format.py
> >
> > diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py
> > index 539f5a186b..d9c41668fd 100755
> > --- a/tests/qemu-iotests/qcow2.py
> > +++ b/tests/qemu-iotests/qcow2.py
> > @@ -1,163 +1,10 @@
> >   #!/usr/bin/env python3
> > -
> >   import sys
>
> Pre-existing: no copyright blurb on the old file...
>
> > +++ b/tests/qemu-iotests/qcow2_format.py
> > @@ -0,0 +1,157 @@
> > +import struct
> > +import string
> > +
>
> It would be nice to fix that, and have one on the new file as well.


Yes, I thought about this.. But what to add? Seems OK to add Virtuozzo copyright and 
common "This program is free software; you can redist... GPL ..." header to 
qcow2_format.py, as we are going to rewrite and improve it a lot. But what to add to 
qcow2.py, to the part which is kept mostly unchanged?

--
Best regards,
Vladimir