Re: [PATCH 1/7] softfloat: merge floatx80_mod and floatx80_rem

[Richard Henderson]

On 6/5/20 11:59 AM, Joseph Myers wrote:
> The m68k-specific softfloat code includes a function floatx80_mod that
> is extremely similar to floatx80_rem, but computing the remainder
> based on truncating the quotient toward zero rather than rounding it
> to nearest integer.  This is also useful for emulating the x87 fprem
> and fprem1 instructions.  Change the floatx80_rem implementation into
> floatx80_modrem that can perform either operation, with both
> floatx80_rem and floatx80_mod as thin wrappers available for all
> targets.
> 
> There does not appear to be any use for the _mod operation for other
> floating-point formats in QEMU (the only other architectures using
> _rem at all are linux-user/arm/nwfpe, for FPA emulation, and openrisc,
> for instructions that have been removed in the latest version of the
> architecture), so no change is made to the code for other formats.
> 
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
>  fpu/softfloat.c         | 49 ++++++++++++++++++------
>  include/fpu/softfloat.h |  2 +
>  target/m68k/softfloat.c | 83 -----------------------------------------
>  target/m68k/softfloat.h |  1 -
>  4 files changed, 40 insertions(+), 95 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~