[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 24/24] qdev: Assert onboard devices all get realized properly
From: |
Markus Armbruster |
Subject: |
[PATCH v3 24/24] qdev: Assert onboard devices all get realized properly |
Date: |
Tue, 9 Jun 2020 14:23:39 +0200 |
This would have caught some of the bugs I just fixed.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/core/qdev.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index b5b42b2616..a68ba674db 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -427,6 +427,19 @@ void qdev_init_nofail(DeviceState *dev)
object_unref(OBJECT(dev));
}
+static int qdev_assert_realized_properly(Object *obj, void *opaque)
+{
+ DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE));
+ DeviceClass *dc;
+
+ if (dev) {
+ dc = DEVICE_GET_CLASS(dev);
+ assert(dev->realized);
+ assert(dev->parent_bus || !dc->bus_type);
+ }
+ return 0;
+}
+
void qdev_machine_creation_done(void)
{
/*
@@ -434,6 +447,9 @@ void qdev_machine_creation_done(void)
* only create hotpluggable devices
*/
qdev_hotplug = true;
+
+ object_child_foreach_recursive(object_get_root(),
+ qdev_assert_realized_properly, NULL);
}
bool qdev_machine_modified(void)
--
2.26.2
- [PATCH v3 05/24] arm/aspeed: Rework NIC attachment, (continued)
- [PATCH v3 05/24] arm/aspeed: Rework NIC attachment, Markus Armbruster, 2020/06/09
- [PATCH v3 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus, Markus Armbruster, 2020/06/09
- [PATCH v3 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices, Markus Armbruster, 2020/06/09
- [PATCH v3 15/24] macio: Fix macio-bus to be a subtype of System bus, Markus Armbruster, 2020/06/09
- [PATCH v3 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init(), Markus Armbruster, 2020/06/09
- [PATCH v3 03/24] sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" device, Markus Armbruster, 2020/06/09
- [PATCH v3 11/24] pnv/phb4: Delete unused "pnv-phb4-pec-stack" devices, Markus Armbruster, 2020/06/09
- [PATCH v3 04/24] arm/aspeed: Compute the number of CPUs from the SoC definition, Markus Armbruster, 2020/06/09
- [PATCH v3 20/24] riscv: Fix type of SiFive[EU]SocState, member parent_obj, Markus Armbruster, 2020/06/09
- [PATCH v3 24/24] qdev: Assert onboard devices all get realized properly,
Markus Armbruster <=
- [PATCH v3 06/24] armv7m: Delete unused "ARM,bitband-memory" devices, Markus Armbruster, 2020/06/09
- [PATCH v3 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc", Markus Armbruster, 2020/06/09
- [PATCH v3 10/24] macio: Delete unused "macio-gpio" devices, Markus Armbruster, 2020/06/09
- [PATCH v3 13/24] ppc4xx: Drop redundant device realization, Markus Armbruster, 2020/06/09
- [PATCH v3 22/24] qdev: Assert devices are plugged into a bus that can take them, Markus Armbruster, 2020/06/09
- [PATCH v3 07/24] auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave, Markus Armbruster, 2020/06/09
- [PATCH v3 19/24] riscv: Fix to put "riscv.hart_array" devices on sysbus, Markus Armbruster, 2020/06/09