[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/15] iotests: Fix 291 across more file systems
From: |
Eric Blake |
Subject: |
[PULL 15/15] iotests: Fix 291 across more file systems |
Date: |
Tue, 9 Jun 2020 15:52:45 -0500 |
Depending on the granularity of holes and amount of metadata consumed
by a file, the 'disk size:' number of 'qemu-img info' is not reliable.
Adjust our test to use a different set of filters to avoid spurious
failures.
Reported-by: Kevin Wolf <kwolf@redhat.com>
Fixes: cf2d1203dc
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200608195629.3299649-1-eblake@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
[eblake: fix merge conflict]
Signed-off-by: Eric Blake <eblake@redhat.com>
---
tests/qemu-iotests/291 | 4 ++--
tests/qemu-iotests/291.out | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/291 b/tests/qemu-iotests/291
index e0cffc7cb119..404f8521f74a 100755
--- a/tests/qemu-iotests/291
+++ b/tests/qemu-iotests/291
@@ -79,7 +79,7 @@ echo
# Only bitmaps from the active layer are copied
$QEMU_IMG convert --bitmaps -O qcow2 "$TEST_IMG.orig" "$TEST_IMG"
-$QEMU_IMG info "$TEST_IMG" | _filter_img_info --format-specific
+_img_info --format-specific
# But we can also merge in bitmaps from other layers. This test is a bit
# contrived to cover more code paths, in reality, you could merge directly
# into b0 without going through tmp
@@ -89,7 +89,7 @@ $QEMU_IMG bitmap --add --merge b0 -b "$TEST_IMG.base" -F
$IMGFMT \
$QEMU_IMG bitmap --merge tmp -f $IMGFMT "$TEST_IMG" b0
$QEMU_IMG bitmap --remove --image-opts \
driver=$IMGFMT,file.driver=file,file.filename="$TEST_IMG" tmp
-$QEMU_IMG info "$TEST_IMG" | _filter_img_info --format-specific
+_img_info --format-specific
echo "Check resulting qcow2 header extensions:"
$PYTHON qcow2.py "$TEST_IMG" dump-header-exts
diff --git a/tests/qemu-iotests/291.out b/tests/qemu-iotests/291.out
index ccfcdc5e35ce..08bfaaaa6b7d 100644
--- a/tests/qemu-iotests/291.out
+++ b/tests/qemu-iotests/291.out
@@ -43,7 +43,7 @@ qemu-img: Format driver 'raw' does not support bitmaps
image: TEST_DIR/t.IMGFMT
file format: IMGFMT
virtual size: 10 MiB (10485760 bytes)
-disk size: 4.39 MiB
+cluster_size: 65536
Format specific information:
compat: 1.1
compression type: zlib
@@ -63,7 +63,7 @@ Format specific information:
image: TEST_DIR/t.IMGFMT
file format: IMGFMT
virtual size: 10 MiB (10485760 bytes)
-disk size: 4.48 MiB
+cluster_size: 65536
Format specific information:
compat: 1.1
compression type: zlib
--
2.27.0
- [PULL 00/15] bitmaps patches for 2020-06-09, Eric Blake, 2020/06/09
- [PULL 01/15] qemu-img: Fix doc typo for 'bitmap' subcommand, Eric Blake, 2020/06/09
- [PULL 05/15] qcow2_format.py: drop new line printing at end of dump(), Eric Blake, 2020/06/09
- [PULL 03/15] qcow2.py: add licensing blurb, Eric Blake, 2020/06/09
- [PULL 04/15] qcow2.py: move qcow2 format classes to separate module, Eric Blake, 2020/06/09
- [PULL 10/15] qcow2_format.py: add field-formatting class, Eric Blake, 2020/06/09
- [PULL 07/15] qcow2_format.py: use modern string formatting, Eric Blake, 2020/06/09
- [PULL 09/15] qcow2_format.py: separate generic functionality of structure classes, Eric Blake, 2020/06/09
- [PULL 02/15] qcow2.py: python style fixes, Eric Blake, 2020/06/09
- [PULL 12/15] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct, Eric Blake, 2020/06/09
- [PULL 15/15] iotests: Fix 291 across more file systems,
Eric Blake <=
- [PULL 06/15] qcow2_format.py: use tuples instead of lists for fields, Eric Blake, 2020/06/09
- [PULL 08/15] qcow2_format.py: use strings to specify c-type of struct fields, Eric Blake, 2020/06/09
- [PULL 11/15] qcow2_format.py: QcowHeaderExtension: add dump method, Eric Blake, 2020/06/09
- [PULL 14/15] qcow2_format.py: dump bitmaps header extension, Eric Blake, 2020/06/09
- [PULL 13/15] qcow2: QcowHeaderExtension print names for extension magics, Eric Blake, 2020/06/09
- Re: [PULL 00/15] bitmaps patches for 2020-06-09, Peter Maydell, 2020/06/11