[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v3 33/58] auxbus: Convert a use of qdev_set_parent_bus()
From: |
Markus Armbruster |
Subject: |
[PATCH RESEND v3 33/58] auxbus: Convert a use of qdev_set_parent_bus() |
Date: |
Wed, 10 Jun 2020 07:32:22 +0200 |
Convert qdev_set_parent_bus()/qdev_init_nofail() to qdev_realize();
recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/display/xlnx_dp.c | 2 +-
hw/misc/auxbus.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index a714cf8a50..884d29c8ce 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -1268,7 +1268,7 @@ static void xlnx_dp_realize(DeviceState *dev, Error
**errp)
aux_bus_realize(s->aux_bus);
- qdev_init_nofail(DEVICE(s->dpcd));
+ qdev_realize(DEVICE(s->dpcd), BUS(s->aux_bus), &error_fatal);
aux_map_slave(AUX_SLAVE(s->dpcd), 0x0000);
qdev_realize_and_unref(DEVICE(s->edid), BUS(aux_get_i2c_bus(s->aux_bus)),
diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c
index 113f4278aa..e7a5d26158 100644
--- a/hw/misc/auxbus.c
+++ b/hw/misc/auxbus.c
@@ -70,7 +70,6 @@ AUXBus *aux_bus_init(DeviceState *parent, const char *name)
bus = AUX_BUS(qbus_create(TYPE_AUX_BUS, parent, name));
auxtoi2c = object_new_with_props(TYPE_AUXTOI2C, OBJECT(bus), "i2c",
&error_abort, NULL);
- qdev_set_parent_bus(DEVICE(auxtoi2c), BUS(bus));
bus->bridge = AUXTOI2C(auxtoi2c);
@@ -83,7 +82,7 @@ AUXBus *aux_bus_init(DeviceState *parent, const char *name)
void aux_bus_realize(AUXBus *bus)
{
- qdev_init_nofail(DEVICE(bus->bridge));
+ qdev_realize(DEVICE(bus->bridge), BUS(bus), &error_fatal);
}
void aux_map_slave(AUXSlave *aux_dev, hwaddr addr)
@@ -280,7 +279,6 @@ DeviceState *aux_create_slave(AUXBus *bus, const char *type)
dev = qdev_new(type);
assert(dev);
- qdev_set_parent_bus(dev, &bus->qbus);
return dev;
}
--
2.26.2
- [PATCH RESEND v3 02/58] Revert "hw/prep: realize the PCI root bus as part of the prep init", (continued)
- [PATCH RESEND v3 02/58] Revert "hw/prep: realize the PCI root bus as part of the prep init", Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 19/58] isa: Convert uses of isa_create() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 30/58] qdev: qdev_create(), qdev_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 22/58] ssi: ssi_auto_connect_slaves() never does anything, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 09/58] qdev: Convert uses of qdev_create() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 26/58] usb: New usb_new(), usb_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 24/58] ssi: Convert last use of ssi_create_slave_no_init() manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 29/58] usb: Eliminate usb_try_create_simple(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 21/58] isa: isa_create(), isa_try_create() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 32/58] auxbus: New aux_bus_realize(), pairing with aux_bus_init(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 33/58] auxbus: Convert a use of qdev_set_parent_bus(),
Markus Armbruster <=
- [PATCH RESEND v3 17/58] pci: pci_create(), pci_create_multifunction() are now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 46/58] qdev: Drop qdev_realize() support for null bus, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 13/58] pci: New pci_new(), pci_realize_and_unref() etc., Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 42/58] hw/arm/armsse: Pass correct child size to sysbus_init_child_obj(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 25/58] ssi: ssi_create_slave_no_init() is now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 15/58] pci: Convert uses of pci_create() etc. with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 44/58] sysbus: New sysbus_realize(), sysbus_realize_and_unref(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 37/58] macio: Convert use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 40/58] microbit: Tidy up sysbus_init_child_obj() @child argument, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 39/58] sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls, Markus Armbruster, 2020/06/10