[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v3 55/58] qdev: Use qdev_realize() in qdev_device_add()
From: |
Markus Armbruster |
Subject: |
[PATCH RESEND v3 55/58] qdev: Use qdev_realize() in qdev_device_add() |
Date: |
Wed, 10 Jun 2020 07:32:44 +0200 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
qdev-monitor.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 20cfa7615b..22da107484 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -661,9 +661,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
goto err_del_dev;
}
- if (bus) {
- qdev_set_parent_bus(dev, bus);
- } else if (qdev_hotplug && !qdev_get_machine_hotplug_handler(dev)) {
+ if (!bus && qdev_hotplug && !qdev_get_machine_hotplug_handler(dev)) {
/* No bus, no machine hotplug handler --> device is not hotpluggable */
error_setg(&err, "Device '%s' can not be hotplugged on this machine",
driver);
@@ -678,7 +676,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
}
dev->opts = opts;
- object_property_set_bool(OBJECT(dev), true, "realized", &err);
+ qdev_realize(DEVICE(dev), bus, &err);
if (err != NULL) {
dev->opts = NULL;
goto err_del_dev;
--
2.26.2
- Re: [PATCH RESEND v3 31/58] auxbus: Rename aux_init_bus() to aux_bus_init(), (continued)
- [PATCH RESEND v3 23/58] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 04/58] qdev: New qdev_new(), qdev_realize(), etc., Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 52/58] microbit: Eliminate two local variables in microbit_init(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 58/58] MAINTAINERS: Make section QOM cover hw/core/*bus.c as well, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 57/58] qdev: qdev_init_nofail() is now unused, drop, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 36/58] qom: Less verbose object_initialize_child(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 27/58] usb: Convert uses of usb_create(), Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 16/58] pci: Convert uses of pci_create() etc. manually, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 55/58] qdev: Use qdev_realize() in qdev_device_add(),
Markus Armbruster <=
- [PATCH RESEND v3 47/58] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 53/58] s390x/event-facility: Simplify creation of SCLP event devices, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 49/58] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 56/58] qdev: Convert bus-less devices to qdev_realize() with Coccinelle, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 48/58] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2, Markus Armbruster, 2020/06/10
- [PATCH RESEND v3 45/58] sysbus: Convert to sysbus_realize() etc. with Coccinelle, Markus Armbruster, 2020/06/10
- Re: [PATCH RESEND v3 00/58] qdev: Rework how we plug into the parent bus, Michael S. Tsirkin, 2020/06/10