[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 01/58] msix: allow qword MSI-X table accesses
From: |
Michael S. Tsirkin |
Subject: |
[PULL v2 01/58] msix: allow qword MSI-X table accesses |
Date: |
Fri, 12 Jun 2020 10:51:02 -0400 |
PCI spec says:
For all accesses to MSI-X Table and MSI-X PBA fields, software must use
aligned full DWORD or aligned full QWORD transactions; otherwise, the
result is undefined.
However, since MSI-X was converted to use memory API, QEMU
started blocking qword transactions, only allowing DWORD
ones. Guests do not seem to use QWORD accesses, but let's
be spec compliant.
Fixes: 95524ae8dc8f ("msix: convert to memory API")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/pci/msix.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index 29187898f2..e6a5559038 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -199,6 +199,9 @@ static const MemoryRegionOps msix_table_mmio_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
.valid = {
.min_access_size = 4,
+ .max_access_size = 8,
+ },
+ .impl = {
.max_access_size = 4,
},
};
@@ -227,6 +230,9 @@ static const MemoryRegionOps msix_pba_mmio_ops = {
.endianness = DEVICE_LITTLE_ENDIAN,
.valid = {
.min_access_size = 4,
+ .max_access_size = 8,
+ },
+ .impl = {
.max_access_size = 4,
},
};
--
MST
- [PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests, Michael S. Tsirkin, 2020/06/12
- [PULL v2 01/58] msix: allow qword MSI-X table accesses,
Michael S. Tsirkin <=
- [PULL v2 03/58] hw/acpi/nvdimm: add a helper to augment SRAT generation, Michael S. Tsirkin, 2020/06/12
- [PULL v2 07/58] acpi: rtc: use a single crs range, Michael S. Tsirkin, 2020/06/12
- [PULL v2 06/58] acpi: move aml builder code for rtc device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 08/58] acpi: serial: don't use _STA method, Michael S. Tsirkin, 2020/06/12
- [PULL v2 10/58] acpi: parallel: don't use _STA method, Michael S. Tsirkin, 2020/06/12
- [PULL v2 09/58] acpi: move aml builder code for serial device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 11/58] acpi: move aml builder code for parallel device, Michael S. Tsirkin, 2020/06/12
- [PULL v2 13/58] acpi: tpm: Do not build TCPA table for TPM 2, Michael S. Tsirkin, 2020/06/12
- [PULL v2 15/58] acpi: Move build_tpm2() in the generic part, Michael S. Tsirkin, 2020/06/12
- [PULL v2 16/58] arm/acpi: TPM2 ACPI table support, Michael S. Tsirkin, 2020/06/12
- Prev by Date:
[PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests
- Next by Date:
[PULL v2 03/58] hw/acpi/nvdimm: add a helper to augment SRAT generation
- Previous by thread:
[PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests
- Next by thread:
[PULL v2 03/58] hw/acpi/nvdimm: add a helper to augment SRAT generation
- Index(es):