[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests
From: |
Michael S. Tsirkin |
Subject: |
Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests |
Date: |
Fri, 12 Jun 2020 12:12:08 -0400 |
On Thu, Jun 11, 2020 at 07:13:35PM +0100, Peter Maydell wrote:
> On Wed, 10 Jun 2020 at 05:26, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2:
> >/tmp/par8snSu.par
>
> > Merge remote-tracking branch
> > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging
> > (2020-06-08 11:04:57 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 23fe04b63b412276c7c2f67c550961af9d0b4e1e:
> >
> > Fix parameter type in vhost migration log path (2020-06-09 14:18:04 -0400)
> >
> > ----------------------------------------------------------------
> > virtio,acpi,pci: features, fixes, cleanups, tests
> >
> > Max slots negotiation for vhost-user.
> > Free page reporting for balloon.
> > Partial TPM2 ACPI support for ARM.
> > Support for NVDIMMs having their own proximity domains.
> > New vhost-user-vsock device.
> >
> > Fixes, cleanups in ACPI, PCI, virtio.
> > New tests for TPM ACPI.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Hi; I'm afraid this has format string issues:
>
> /Users/pm215/src/qemu-for-merges/hw/virtio/vhost-user.c:759:51: error:
> format specifies type 'unsigned long' but the argument has type
> 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
> "%lX", __func__, reply_gpa,
> ^~~~~~~~~
> /Users/pm215/src/qemu-for-merges/hw/virtio/vhost-user.c:760:34: error:
> format specifies type 'unsigned long' but the argument has type
> 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
> dev->mem->regions[reg_idx].guest_phys_addr);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /Users/pm215/src/qemu-for-merges/hw/virtio/vhost-user.c:1876:67:
> error: format specifies type 'unsigned long' but the argument has type
> 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
> "This limit should never decrease.", ram_slots,
> ^~~~~~~~~
>
> (repros on OSX, OpenBSD, and 32-bit hosts)
>
> thanks
> -- PMM
Fixed and sent v2, thanks!
--
MST
- [PULL 26/56] virtio-balloon: Provide an interface for free page reporting, (continued)
- [PULL 26/56] virtio-balloon: Provide an interface for free page reporting, Michael S. Tsirkin, 2020/06/10
- [PULL 53/56] acpi: madt: skip pci override on pci-less systems., Michael S. Tsirkin, 2020/06/10
- [PULL 43/56] Support adding individual regions in libvhost-user, Michael S. Tsirkin, 2020/06/10
- [PULL 37/56] Add vhost-user helper to get MemoryRegion data, Michael S. Tsirkin, 2020/06/10
- [PULL 52/56] acpi: create acpi-common.c and move madt code, Michael S. Tsirkin, 2020/06/10
- [PULL 54/56] acpi: fadt: add hw-reduced sleep register support, Michael S. Tsirkin, 2020/06/10
- [PULL 51/56] acpi: make build_madt() more generic., Michael S. Tsirkin, 2020/06/10
- [PULL 49/56] virtio: add vhost-user-vsock base device, Michael S. Tsirkin, 2020/06/10
- Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests, no-reply, 2020/06/10
- Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests, Peter Maydell, 2020/06/11
- Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests,
Michael S. Tsirkin <=
- Prev by Date:
[PULL v2 000/116] Huge miscellaneous pull request for 2020-06-11
- Next by Date:
Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests
- Previous by thread:
Re: [PULL 00/56] virtio,acpi,pci: features, fixes, cleanups, tests
- Next by thread:
Clarification regarding new qemu-img convert --target-is-zero flag
- Index(es):