[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/4] sm501: Optimise 1 pixel 2d ops
From: |
Gerd Hoffmann |
Subject: |
[PULL 4/4] sm501: Optimise 1 pixel 2d ops |
Date: |
Mon, 15 Jun 2020 17:14:49 +0200 |
From: BALATON Zoltan <balaton@eik.bme.hu>
Some guests do 1x1 blits which is faster to do directly than calling a
function for it so avoid overhead in this case.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-id:
9fab4fe6513fe8b921ce86a57f4ff7e0d5a3c3f9.1591471056.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/sm501.c | 40 +++++++++++++++++++++++++++++++++++++---
1 file changed, 37 insertions(+), 3 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 3397ca9fbf4c..59693fbb5c17 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -793,6 +793,25 @@ static void sm501_2d_operation(SM501State *s)
src_x == dst_x && src_y == dst_y) {
break;
}
+ /* Some clients also do 1 pixel blits, avoid overhead for these */
+ if (width == 1 && height == 1) {
+ unsigned int si = (src_x + src_y * src_pitch) * (1 << format);
+ unsigned int di = (dst_x + dst_y * dst_pitch) * (1 << format);
+ switch (format) {
+ case 0:
+ s->local_mem[dst_base + di] = s->local_mem[src_base + si];
+ break;
+ case 1:
+ *(uint16_t *)&s->local_mem[dst_base + di] =
+ *(uint16_t *)&s->local_mem[src_base + si];
+ break;
+ case 2:
+ *(uint32_t *)&s->local_mem[dst_base + di] =
+ *(uint32_t *)&s->local_mem[src_base + si];
+ break;
+ }
+ break;
+ }
/* Check for overlaps, this could be made more exact */
uint32_t sb, se, db, de;
sb = src_base + src_x + src_y * (width + src_pitch);
@@ -841,9 +860,24 @@ static void sm501_2d_operation(SM501State *s)
color = cpu_to_le16(color);
}
- pixman_fill((uint32_t *)&s->local_mem[dst_base],
- dst_pitch * (1 << format) / sizeof(uint32_t),
- 8 * (1 << format), dst_x, dst_y, width, height, color);
+ if (width == 1 && height == 1) {
+ unsigned int i = (dst_x + dst_y * dst_pitch) * (1 << format);
+ switch (format) {
+ case 0:
+ s->local_mem[dst_base + i] = color & 0xff;
+ break;
+ case 1:
+ *(uint16_t *)&s->local_mem[dst_base + i] = color & 0xffff;
+ break;
+ case 2:
+ *(uint32_t *)&s->local_mem[dst_base + i] = color;
+ break;
+ }
+ } else {
+ pixman_fill((uint32_t *)&s->local_mem[dst_base],
+ dst_pitch * (1 << format) / sizeof(uint32_t),
+ 8 * (1 << format), dst_x, dst_y, width, height, color);
+ }
break;
}
default:
--
2.18.4
- [PULL 0/4] Vga 20200615 patches, Gerd Hoffmann, 2020/06/15
- [PULL 2/4] sm501: Drop unneded variable, Gerd Hoffmann, 2020/06/15
- [PULL 3/4] sm501: Ignore no-op blits, Gerd Hoffmann, 2020/06/15
- [PULL 4/4] sm501: Optimise 1 pixel 2d ops,
Gerd Hoffmann <=
- [PULL 1/4] sm501: Fix bounds checks, Gerd Hoffmann, 2020/06/15
- Re: [PULL 0/4] Vga 20200615 patches, Peter Maydell, 2020/06/15
- Re: [PULL 0/4] Vga 20200615 patches, BALATON Zoltan, 2020/06/15