[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 5/5] hw/arm/tosa: Use LED device for the Bluetooth led
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH v2 5/5] hw/arm/tosa: Use LED device for the Bluetooth led |
Date: |
Mon, 15 Jun 2020 17:00:48 +0100 |
On Fri, 12 Jun 2020 at 18:54, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/arm/tosa.c | 7 +++----
> hw/arm/Kconfig | 1 +
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
> index 5dee2d76c6..86d7e0283a 100644
> --- a/hw/arm/tosa.c
> +++ b/hw/arm/tosa.c
> @@ -24,6 +24,7 @@
> #include "hw/irq.h"
> #include "hw/ssi/ssi.h"
> #include "hw/sysbus.h"
> +#include "hw/misc/led.h"
> #include "exec/address-spaces.h"
>
> #define TOSA_RAM 0x04000000
> @@ -68,9 +69,6 @@ static void tosa_microdrive_attach(PXA2xxState *cpu)
> static void tosa_out_switch(void *opaque, int line, int level)
> {
> switch (line) {
> - case 0:
> - fprintf(stderr, "blue LED %s.\n", level ? "on" : "off");
> - break;
> case 1:
> fprintf(stderr, "green LED %s.\n", level ? "on" : "off");
> break;
Why convert the blue LED and not the green, amber or wlan LEDs ?
thanks
-- PMM
- Re: [RFC PATCH v2 1/5] hw/misc: Add a LED device, (continued)
[RFC PATCH v2 2/5] hw/misc/led: Add LED_STATUS_CHANGED QAPI event, Philippe Mathieu-Daudé, 2020/06/12
[RFC PATCH v2 3/5] hw/misc/led: Add create_led_by_gpio_id() helper, Philippe Mathieu-Daudé, 2020/06/12
[RFC PATCH v2 4/5] hw/arm/microbit: Add a fake LED to use as proof-of-concept with Zephyr, Philippe Mathieu-Daudé, 2020/06/12
[RFC PATCH v2 5/5] hw/arm/tosa: Use LED device for the Bluetooth led, Philippe Mathieu-Daudé, 2020/06/12
- Re: [RFC PATCH v2 5/5] hw/arm/tosa: Use LED device for the Bluetooth led,
Peter Maydell <=