Re: [PATCH v2 1/2] qemu-options.hx: Mark all hmat-cache attributes required

[Michal Privoznik]

On 6/15/20 10:00 AM, Markus Armbruster wrote:
> Cc: the people involved in commit c412a48d4d "numa: Extend CLI to
> provide memory side cache information".
>
> Michal Privoznik <mprivozn@redhat.com> writes:
>
> > The documentation to `-numa hmat-cache` says that @node-id, @size
> > and @level are the only required attributes. The rest
> > (@associativity, @policy and @line) is optional. Well, not quite
> > - if I try to start QEMU with only the three required attributes
> > defined the QAPI code is complaining about associativity missing.
>
> Only because @associativity visited first.
>
> > According to QAPI all attributes are required. Make the docs
> > reflect that.
>
> Correct.
>
> > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > ---
> >   qemu-options.hx | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)

> Assuming non-optional is what we want:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Indeed, it is:

https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg08411.html

Thanks,
Michal