[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/7] bios-tables-test: Fix "-tpmdev: invalid option"
From: |
Thomas Huth |
Subject: |
[PULL 1/7] bios-tables-test: Fix "-tpmdev: invalid option" |
Date: |
Tue, 16 Jun 2020 10:58:07 +0200 |
From: Eric Auger <eric.auger@redhat.com>
When configure is run with "--disable-tpm", the bios-tables-test
q35/tis test fails with "-tpmdev: invalid option".
Skip the test if CONFIG_TPM is unset.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200615135051.2213-1-eric.auger@redhat.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Fixes: 5da7c35e25 ("bios-tables-test: Add Q35/TPM-TIS test")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/bios-tables-test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 53f104a9c5..b482f76c03 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -882,6 +882,7 @@ uint64_t tpm_tis_base_addr;
static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
uint64_t base)
{
+#ifdef CONFIG_TPM
gchar *tmp_dir_name = g_strdup_printf("qemu-test_acpi_%s_tcg_%s.XXXXXX",
machine, tpm_if);
char *tmp_path = g_dir_make_tmp(tmp_dir_name, NULL);
@@ -924,6 +925,9 @@ static void test_acpi_tcg_tpm(const char *machine, const
char *tpm_if,
g_free(tmp_path);
g_free(tmp_dir_name);
free_test_data(&data);
+#else
+ g_test_skip("TPM disabled");
+#endif
}
static void test_acpi_q35_tcg_tpm_tis(void)
--
2.18.1
- [PULL 0/7] fuzzing and other test-related patches, Thomas Huth, 2020/06/16
- [PULL 1/7] bios-tables-test: Fix "-tpmdev: invalid option",
Thomas Huth <=
- [PULL 2/7] fuzz: skip QTest serialization, Thomas Huth, 2020/06/16
- [PULL 3/7] fuzz: Add support for logging QTest commands, Thomas Huth, 2020/06/16
- [PULL 4/7] fuzz: add oss-fuzz build-script, Thomas Huth, 2020/06/16
- [PULL 5/7] tests/qtest: Fix LGPL information in the file headers, Thomas Huth, 2020/06/16
- [PULL 6/7] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image, Thomas Huth, 2020/06/16
- [PULL 7/7] configure: Let SLOF be initialized by ./scripts/git-submodule.sh, Thomas Huth, 2020/06/16
- Re: [PULL 0/7] fuzzing and other test-related patches, Peter Maydell, 2020/06/16