[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons
From: |
Peter Maydell |
Subject: |
Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons |
Date: |
Tue, 16 Jun 2020 11:27:11 +0100 |
On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The FPGA system control block has 2 push-buttons labelled PB0/PB1.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj)
> memory_region_init_io(&s->iomem, obj, &mps2_fpgaio_ops, s,
> "mps2-fpgaio", 0x1000);
> sysbus_init_mmio(sbd, &s->iomem);
> +
> + qdev_init_gpio_in_named(DEVICE(s), mps2_fpgaio_push_button, "PB", 2);
> }
This change seems kind of pointless unless these GPIO lines are
actually wired up to something.
thanks
-- PMM
- [PATCH 1/7] hw/arm/mps2: Rename CMSDK AHB peripheral region, (continued)
- [PATCH 1/7] hw/arm/mps2: Rename CMSDK AHB peripheral region, Philippe Mathieu-Daudé, 2020/06/16
- [PATCH 5/7] hw/arm/mps2: Add I2C busses on FPGA APB, Philippe Mathieu-Daudé, 2020/06/16
- [PATCH 3/7] hw/arm/mps2: Add CMSDK APB watchdog as unimplemented device, Philippe Mathieu-Daudé, 2020/06/16
- [PATCH 4/7] hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices, Philippe Mathieu-Daudé, 2020/06/16
- [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons, Philippe Mathieu-Daudé, 2020/06/16
- Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons,
Peter Maydell <=
[PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block, Philippe Mathieu-Daudé, 2020/06/16