[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 05/14] block/amend: refactor qcow2 amend options
From: |
Max Reitz |
Subject: |
Re: [PATCH v8 05/14] block/amend: refactor qcow2 amend options |
Date: |
Tue, 16 Jun 2020 15:23:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 08.06.20 11:40, Maxim Levitsky wrote:
> Some qcow2 create options can't be used for amend.
> Remove them from the qcow2 create options and add generic logic to detect
> such options in qemu-img
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Last week (when I was about to prepare a pull request), I noticed that
this patch breaks the iotests 134 and 158 for qcow (v1). That’s because
as of this patch, qcow2 has a different order of creation options than qcow.
We could easily fix this by moving HEAD^:134.out and HEAD^:158.out to
134.out.qcow and 158.out.qcow, respectively, and HEAD:134.out and
HEAD:158.out to 134.out.qcow2 and 158.out.qcow2, respectively.
But the underlying problem is a greater one: The order of creation
options isn’t fixed between different formats, so I think
_filter_img_create should sort it so it’s the same for all.
To do so, I just sent the “iotests: Make _filter_img_create more active”
series. We could put that underneath your series and then the problem
would be fixed, too (and we could drop some of the hunks from this
patch, because the option order wouldn’t change for any test that uses
_filter_img_create).
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH v8 00/14] LUKS: encryption slot management using amend interface, Maxim Levitsky, 2020/06/08
- [PATCH v8 01/14] qcrypto/core: add generic infrastructure for crypto options amendment, Maxim Levitsky, 2020/06/08
- [PATCH v8 02/14] qcrypto/luks: implement encryption key management, Maxim Levitsky, 2020/06/08
- [PATCH v8 03/14] block/amend: add 'force' option, Maxim Levitsky, 2020/06/08
- [PATCH v8 04/14] block/amend: separate amend and create options for qemu-img, Maxim Levitsky, 2020/06/08
- [PATCH v8 06/14] block/crypto: rename two functions, Maxim Levitsky, 2020/06/08
- [PATCH v8 05/14] block/amend: refactor qcow2 amend options, Maxim Levitsky, 2020/06/08
- Re: [PATCH v8 05/14] block/amend: refactor qcow2 amend options,
Max Reitz <=
- [PATCH v8 08/14] block/qcow2: extend qemu-img amend interface with crypto options, Maxim Levitsky, 2020/06/08
- [PATCH v8 07/14] block/crypto: implement the encryption key management, Maxim Levitsky, 2020/06/08
- [PATCH v8 09/14] iotests: filter few more luks specific create options, Maxim Levitsky, 2020/06/08
- [PATCH v8 10/14] iotests: qemu-img tests for luks key management, Maxim Levitsky, 2020/06/08
- [PATCH v8 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command, Maxim Levitsky, 2020/06/08
- [PATCH v8 12/14] block/crypto: implement blockdev-amend, Maxim Levitsky, 2020/06/08
- [PATCH v8 13/14] block/qcow2: implement blockdev-amend, Maxim Levitsky, 2020/06/08
- [PATCH v8 14/14] iotests: add tests for blockdev-amend, Maxim Levitsky, 2020/06/08