[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] prep: add ppc-parity write method
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 4/6] prep: add ppc-parity write method |
Date: |
Wed, 17 Jun 2020 09:47:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/17/20 7:39 AM, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Add ppc-parity mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun <slei.casper@gmail.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/ppc/prep_systemio.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/ppc/prep_systemio.c b/hw/ppc/prep_systemio.c
> index bbc51b6e9a..aacd7831fd 100644
> --- a/hw/ppc/prep_systemio.c
> +++ b/hw/ppc/prep_systemio.c
> @@ -23,6 +23,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/irq.h"
> #include "hw/isa/isa.h"
> #include "hw/qdev-properties.h"
> @@ -235,8 +236,15 @@ static uint64_t ppc_parity_error_readl(void *opaque,
> hwaddr addr,
> return val;
> }
>
> +static void ppc_parity_error_writel(void *opaque, hwaddr addr,
> + uint64_t data, unsigned size)
> +{
> + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
I understand the parity bits are calculated by the hardware, I doubt we
can write them. So probably LOG_GUEST_ERROR or a transaction failure here.
> +}
> +
> static const MemoryRegionOps ppc_parity_error_ops = {
> .read = ppc_parity_error_readl,
> + .write = ppc_parity_error_writel,
> .valid = {
> .min_access_size = 4,
> .max_access_size = 4,
>
- [PATCH 0/6] Add various undefined MMIO r/w functions, P J P, 2020/06/17
- [PATCH 1/6] hw/pci-host: add pci-intack write method, P J P, 2020/06/17
- [PATCH 2/6] pci-host: add pcie-msi read method, P J P, 2020/06/17
- [PATCH 3/6] vfio: add quirk device write method, P J P, 2020/06/17
- [PATCH 4/6] prep: add ppc-parity write method, P J P, 2020/06/17
- Re: [PATCH 4/6] prep: add ppc-parity write method,
Philippe Mathieu-Daudé <=
- [PATCH 5/6] nvram: add nrf51_soc flash read method, P J P, 2020/06/17
- [PATCH 6/6] spapr_pci: add spapr msi read method, P J P, 2020/06/17
- Re: [PATCH 0/6] Add various undefined MMIO r/w functions, no-reply, 2020/06/17
- Re: [PATCH 0/6] Add various undefined MMIO r/w functions, David Gibson, 2020/06/17