[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script
From: |
Ahmed Karaman |
Subject: |
Re: [PATCH 3/3] scripts/performance: Add perf_top_25.py script |
Date: |
Wed, 17 Jun 2020 18:15:12 +0200 |
On Wed, Jun 17, 2020 at 2:21 PM Alex Bennée <alex.bennee@linaro.org> wrote:
> > +
> > +# Run perf repcord and report
> > +os.system('sudo perf record {} {} 2> /dev/null \
> > + && sudo perf report --stdio > tmp.perf.data'
> > + .format(qemu_path, executable))
>
> Why sudo?
This is the default requirement by perf. You can modify the
kernel.perf_event_paranoid setting to run without root privileges.
> Also redirecting just stderr? why?
Perf, as well as Valgrind, print their output on stderr not stdout.
> I think you could separate the steps (as well as use the subprocess
> api).
Noted!
> Again os.unlink()
Noted!
- Re: [PATCH 1/3] MAINTAINERS: Add 'Miscellaneous' section, (continued)
Re: [PATCH 0/3] Add Scripts for Finding Top 25 Executed Functions, no-reply, 2020/06/16
Re: [PATCH 0/3] Add Scripts for Finding Top 25 Executed Functions, Eric Blake, 2020/06/17
Re: [PATCH 0/3] Add Scripts for Finding Top 25 Executed Functions, Ahmed Karaman, 2020/06/17