[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] python/machine.py: refactor shutdown
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 0/3] python/machine.py: refactor shutdown |
Date: |
Wed, 17 Jun 2020 19:15:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/4/20 9:52 PM, John Snow wrote:
> v3:
> - Split _post_shutdown refactor into own patch (now 1/3)
> - Re-add sigkill warning squelch (now 3/3)
>
> NOTE: I re-added the squelch in its own patch for review purposes, but
> for the purposes of avoiding temporary breakage, a maintainer may wish
> to squash patches 2 and 3 if they are accepted.
>
> v2: Philippe took patches 1, 3 and 4.
>
> This is a re-write of what was:
> [PATCH RFC 03/32] python//machine.py: remove bare except
> [PATCH 2/4] python/machine.py: remove bare except
>
> It's a bit heavier handed, but it should address some of kwolf's
> feedback from the RFC version.
>
> Applies straight to origin/master, ought to pass pylint and flake8:
>
>> cd ~/src/qemu/python/qemu
>> pylint *.py
>> flake8 *.py
>
> John Snow (3):
> python/machine.py: consolidate _post_shutdown()
> python/machine.py: refactor shutdown
> python/machine.py: re-add sigkill warning suppression
>
> python/qemu/machine.py | 100 +++++++++++++++++++++++++++++------------
> 1 file changed, 71 insertions(+), 29 deletions(-)
>
I had prepared:
Thanks, applied to my python-next tree (including your
diff in python/qemu/machine.py):
https://gitlab.com/philmd/qemu/commits/python-next
But I just noticed Cleber review comment asking for more testing,
so I'm keeping this applied, but will delay the pull request
since I have to re-run the testing.
Phil.
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, (continued)
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Cleber Rosa, 2020/06/16
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/17
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/20
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, John Snow, 2020/06/22
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/22
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, John Snow, 2020/06/22
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/06/22
- Re: [PATCH v3 0/3] python/machine.py: refactor shutdown, John Snow, 2020/06/26
Re: [PATCH v3 0/3] python/machine.py: refactor shutdown,
Philippe Mathieu-Daudé <=