[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Add various undefined MMIO r/w functions
From: |
P J P |
Subject: |
Re: [PATCH 0/6] Add various undefined MMIO r/w functions |
Date: |
Wed, 17 Jun 2020 23:27:33 +0530 (IST) |
+-- On Wed, 17 Jun 2020, Paolo Bonzini wrote --+
| On 17/06/20 15:20, Philippe Mathieu-Daudé wrote:
| > On 6/17/20 3:06 PM, Alex Williamson wrote:
| >> On Wed, 17 Jun 2020 16:39:56 +1000
| >> David Gibson <david@gibson.dropbear.id.au> wrote:
| >>> Hrm. If this is such a common problem, maybe we should just add a NULL
| >>> check in the common paths.
| >>
| >> +1, clearly the behavior is already expected. Thanks,
| >
| > 20 months ago Peter suggested:
| >
| > "assert that every MemoryRegionOps has pointers to callbacks
| > in it, when it is registered in memory_region_init_io() and
| > memory_region_init_rom_device_nomigrate()."
| >
| > https://www.mail-archive.com/qemu-devel@nongnu.org/msg573310.html
| >
| > Li Qiang refers to this post from Paolo:
| >
| >> static const MemoryRegionOps notdirty_mem_ops = {
| >> + .read = notdirty_mem_read,
| >> .write = notdirty_mem_write,
| >> .valid.accepts = notdirty_mem_accepts,
| >> .endianness = DEVICE_NATIVE_ENDIAN,
| >
| > "This cannot happen, since TLB_NOTDIRTY is only added
| > to the addr_write member (see accel/tcg/cputlb.c)."
|
| I'm now okay with asserting it, as long as notdirty_mem_read abort()s.
Okay, I'm preparing a revised patch.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
- Re: [PATCH 5/6] nvram: add nrf51_soc flash read method, (continued)