[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/audio/gus: Fix registers 32-bit access
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] hw/audio/gus: Fix registers 32-bit access |
Date: |
Thu, 18 Jun 2020 12:35:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/18/20 12:23 PM, Peter Maydell wrote:
> On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>>
>> On 6/17/20 10:23 PM, Peter Maydell wrote:
>>> On Mon, 15 Jun 2020 at 22:23, Allan Peramaki <aperamak@pp1.inet.fi> wrote:
>>>>
>>>> Fix audio on software that accesses DRAM above 64k via register peek/poke
>>>> and some cases when more than 16 voices are used.
>>>>
>>>> Fixes: 135f5ae1974c ("audio: GUSsample is int16_t")
>>>> Signed-off-by: Allan Peramaki <aperamak@pp1.inet.fi>
>>>
>>> This patch is quite difficult to read because it mixes some
>>> whitespace only changes with some actual changes of
>>> behaviour.
>>
>> In such cases the author might add a comment in the commit
>> description "this patch is easier to review with git-diff -w"
>> or other options.
>>
>> Allan, can we get the patch with only the changed lines?
>
> Is it worth the effort of a respin at this point?
>
I'll give it a try to see if it takes me less than 2min.