[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL V2 27/33] net/colo-compare.c: Only hexdump packets if tracing is e
From: |
Jason Wang |
Subject: |
[PULL V2 27/33] net/colo-compare.c: Only hexdump packets if tracing is enabled |
Date: |
Thu, 18 Jun 2020 21:21:42 +0800 |
From: Lukas Straub <lukasstraub2@web.de>
Else the log will be flooded if there is a lot of network
traffic.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/colo-compare.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 62ecd38..a609f49 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -483,10 +483,12 @@ sec:
g_queue_push_head(&conn->primary_list, ppkt);
g_queue_push_head(&conn->secondary_list, spkt);
- qemu_hexdump((char *)ppkt->data, stderr,
- "colo-compare ppkt", ppkt->size);
- qemu_hexdump((char *)spkt->data, stderr,
- "colo-compare spkt", spkt->size);
+ if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) {
+ qemu_hexdump((char *)ppkt->data, stderr,
+ "colo-compare ppkt", ppkt->size);
+ qemu_hexdump((char *)spkt->data, stderr,
+ "colo-compare spkt", spkt->size);
+ }
colo_compare_inconsistency_notify(s);
}
--
2.5.0
- [PULL V2 18/33] net: cadence_gem: Add support for jumbo frames, (continued)
- [PULL V2 18/33] net: cadence_gem: Add support for jumbo frames, Jason Wang, 2020/06/18
- [PULL V2 17/33] net: cadence_gem: Fix up code style, Jason Wang, 2020/06/18
- [PULL V2 20/33] net: cadence_gem: Update the reset value for interrupt mask register, Jason Wang, 2020/06/18
- [PULL V2 19/33] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg, Jason Wang, 2020/06/18
- [PULL V2 21/33] net: cadence_gem: TX_LAST bit should be set by guest, Jason Wang, 2020/06/18
- [PULL V2 22/33] net: cadence_gem: Fix RX address filtering, Jason Wang, 2020/06/18
- [PULL V2 23/33] net: use peer when purging queue in qemu_flush_or_purge_queue_packets(), Jason Wang, 2020/06/18
- [PULL V2 24/33] net/colo-compare.c: Create event_bh with the right AioContext, Jason Wang, 2020/06/18
- [PULL V2 25/33] chardev/char.c: Use qemu_co_sleep_ns if in coroutine, Jason Wang, 2020/06/18
- [PULL V2 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send, Jason Wang, 2020/06/18
- [PULL V2 27/33] net/colo-compare.c: Only hexdump packets if tracing is enabled,
Jason Wang <=
- [PULL V2 28/33] net/colo-compare.c: Check that colo-compare is active, Jason Wang, 2020/06/18
- [PULL V2 29/33] net/colo-compare.c: Correct ordering in complete and finalize, Jason Wang, 2020/06/18
- [PULL V2 31/33] hw/net/e1000e: Do not abort() on invalid PSRCTL register value, Jason Wang, 2020/06/18
- [PULL V2 32/33] net: Drop the legacy "name" parameter from the -net option, Jason Wang, 2020/06/18
- [PULL V2 33/33] net: Drop the NetLegacy structure, always use Netdev instead, Jason Wang, 2020/06/18
- [PULL V2 30/33] colo-compare: Fix memory leak in packet_enqueue(), Jason Wang, 2020/06/18
- Re: [PULL V2 00/33] Net patches, no-reply, 2020/06/18