[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 00/10] acpi: i386 tweaks
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v9 00/10] acpi: i386 tweaks |
Date: |
Thu, 18 Jun 2020 16:09:17 -0400 |
On Wed, Jun 17, 2020 at 09:11:28AM +0200, Gerd Hoffmann wrote:
> First batch of microvm patches, some generic acpi stuff.
> Split the acpi-build.c monster, specifically split the
> pc and q35 and pci bits into a separate file which we
> can skip building at some point in the future.
Thanks for the patches!
Pls take a look at tests/qtest/bios-tables-test.c, the comment
at top of this file outlines the process to use for
changing expected test files.
As it is, the patches won't be easily rebaseable or backportable.
> v2 changes: leave acpi-build.c largely as-is, move useful
> bits to other places to allow them being reused, specifically:
>
> * move isa device generator functions to individual isa devices.
> * move fw_cfg generator function to fw_cfg.c
>
> v3 changes: fix rtc, support multiple lpt devices.
>
> v4 changes:
> * drop merged patches.
> * split rtc crs change to separata patch.
> * added two cleanup patches.
> * picked up ack & review tags.
>
> v5 changes:
> * add comment for rtc crs update.
> * add even more cleanup patches.
> * picked up ack & review tags.
>
> v6 changes:
> * floppy: move cmos_get_fd_drive_type.
> * picked up ack & review tags.
>
> v7 changes:
> * rebased to mst/pci branch, resolved stubs conflict.
> * dropped patches already queued up in mst/pci.
> * added missing sign-off.
> * picked up ack & review tags.
>
> v8 changes:
> * (re-)add patch to allow acpi table changes
>
> v9 changes:
> * add asl changes to commit messages.
> * update acpi test data.
>
> take care,
> Gerd
>
> Gerd Hoffmann (10):
> acpi: bios-tables-test: show more context on asl diffs
> acpi: move aml builder code for floppy device
> floppy: make isa_fdc_get_drive_max_chs static
> floppy: move cmos_get_fd_drive_type() from pc
> acpi: move aml builder code for i8042 (kbd+mouse) device
> acpi: factor out fw_cfg_add_acpi_dsdt()
> acpi: simplify build_isa_devices_aml()
> acpi: drop serial/parallel enable bits from dsdt
> acpi: drop build_piix4_pm()
> acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
>
> hw/i386/fw_cfg.h | 1 +
> include/hw/block/fdc.h | 3 +-
> include/hw/i386/pc.h | 1 -
> hw/block/fdc.c | 111 +++++++++++++++-
> hw/i386/acpi-build.c | 210 +-----------------------------
> hw/i386/fw_cfg.c | 28 ++++
> hw/i386/pc.c | 25 ----
> hw/input/pckbd.c | 31 +++++
> stubs/cmos.c | 7 +
> tests/qtest/bios-tables-test.c | 2 +-
> stubs/Makefile.objs | 1 +
> tests/data/acpi/pc/DSDT | Bin 5014 -> 4934 bytes
> tests/data/acpi/pc/DSDT.acpihmat | Bin 6338 -> 6258 bytes
> tests/data/acpi/pc/DSDT.bridge | Bin 6873 -> 6793 bytes
> tests/data/acpi/pc/DSDT.cphp | Bin 5477 -> 5397 bytes
> tests/data/acpi/pc/DSDT.dimmpxm | Bin 6667 -> 6587 bytes
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 5086 -> 5006 bytes
> tests/data/acpi/pc/DSDT.memhp | Bin 6373 -> 6293 bytes
> tests/data/acpi/pc/DSDT.numamem | Bin 5020 -> 4940 bytes
> tests/data/acpi/q35/DSDT | Bin 7752 -> 7678 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9076 -> 9002 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 7769 -> 7695 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8215 -> 8141 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9405 -> 9331 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 7827 -> 7753 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9111 -> 9037 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 8882 -> 8808 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 7758 -> 7684 bytes
> tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8283 bytes
> 29 files changed, 185 insertions(+), 235 deletions(-)
> create mode 100644 stubs/cmos.c
>
> --
> 2.18.4
- [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt(), (continued)
- [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/06/17
- [PATCH v9 07/10] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/06/17
- [PATCH v9 09/10] acpi: drop build_piix4_pm(), Gerd Hoffmann, 2020/06/17
- [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/06/17
- [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks,
Michael S. Tsirkin <=