[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 05/12] floppy: move cmos_get_fd_drive_type() from pc
From: |
Gerd Hoffmann |
Subject: |
[PATCH v10 05/12] floppy: move cmos_get_fd_drive_type() from pc |
Date: |
Fri, 19 Jun 2020 11:18:58 +0200 |
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>
---
include/hw/block/fdc.h | 1 +
include/hw/i386/pc.h | 1 -
hw/block/fdc.c | 26 +++++++++++++++++++++++++-
hw/i386/pc.c | 25 -------------------------
4 files changed, 26 insertions(+), 27 deletions(-)
diff --git a/include/hw/block/fdc.h b/include/hw/block/fdc.h
index 5d71cf972268..479cebc0a330 100644
--- a/include/hw/block/fdc.h
+++ b/include/hw/block/fdc.h
@@ -16,5 +16,6 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
DriveInfo **fds, qemu_irq *fdc_tc);
FloppyDriveType isa_fdc_get_drive_type(ISADevice *fdc, int i);
+int cmos_get_fd_drive_type(FloppyDriveType fd0);
#endif
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 8d764f965cd3..5e3b19ab78fc 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -176,7 +176,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg);
void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs);
ISADevice *pc_find_fdc0(void);
-int cmos_get_fd_drive_type(FloppyDriveType fd0);
/* port92.c */
#define PORT92_A20_LINE "a20"
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 5a634ab46302..ffe650b17cd5 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -32,7 +32,6 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/timer.h"
-#include "hw/i386/pc.h"
#include "hw/acpi/aml-build.h"
#include "hw/irq.h"
#include "hw/isa/isa.h"
@@ -2809,6 +2808,31 @@ static Aml *build_fdinfo_aml(int idx, FloppyDriveType
type)
return dev;
}
+int cmos_get_fd_drive_type(FloppyDriveType fd0)
+{
+ int val;
+
+ switch (fd0) {
+ case FLOPPY_DRIVE_TYPE_144:
+ /* 1.44 Mb 3"5 drive */
+ val = 4;
+ break;
+ case FLOPPY_DRIVE_TYPE_288:
+ /* 2.88 Mb 3"5 drive */
+ val = 5;
+ break;
+ case FLOPPY_DRIVE_TYPE_120:
+ /* 1.2 Mb 5"5 drive */
+ val = 2;
+ break;
+ case FLOPPY_DRIVE_TYPE_NONE:
+ default:
+ val = 0;
+ break;
+ }
+ return val;
+}
+
static void fdc_isa_build_aml(ISADevice *isadev, Aml *scope)
{
Aml *dev;
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index ec39741c87ac..7e0ed987b164 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -386,31 +386,6 @@ static uint64_t ioportF0_read(void *opaque, hwaddr addr,
unsigned size)
#define REG_EQUIPMENT_BYTE 0x14
-int cmos_get_fd_drive_type(FloppyDriveType fd0)
-{
- int val;
-
- switch (fd0) {
- case FLOPPY_DRIVE_TYPE_144:
- /* 1.44 Mb 3"5 drive */
- val = 4;
- break;
- case FLOPPY_DRIVE_TYPE_288:
- /* 2.88 Mb 3"5 drive */
- val = 5;
- break;
- case FLOPPY_DRIVE_TYPE_120:
- /* 1.2 Mb 5"5 drive */
- val = 2;
- break;
- case FLOPPY_DRIVE_TYPE_NONE:
- default:
- val = 0;
- break;
- }
- return val;
-}
-
static void cmos_init_hd(ISADevice *s, int type_ofs, int info_ofs,
int16_t cylinders, int8_t heads, int8_t sectors)
{
--
2.18.4
- [PATCH v10 01/12] qtest: allow DSDT acpi table changes, (continued)
- [PATCH v10 01/12] qtest: allow DSDT acpi table changes, Gerd Hoffmann, 2020/06/19
- [PATCH v10 02/12] acpi: bios-tables-test: show more context on asl diffs, Gerd Hoffmann, 2020/06/19
- [PATCH v10 06/12] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/06/19
- [PATCH v10 04/12] floppy: make isa_fdc_get_drive_max_chs static, Gerd Hoffmann, 2020/06/19
- [PATCH v10 12/12] tests/acpi: update expected data files, Gerd Hoffmann, 2020/06/19
- [PATCH v10 10/12] acpi: drop build_piix4_pm(), Gerd Hoffmann, 2020/06/19
- [PATCH v10 09/12] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/06/19
- [PATCH v10 11/12] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion., Gerd Hoffmann, 2020/06/19
- [PATCH v10 07/12] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/06/19
- [PATCH v10 08/12] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/06/19
- [PATCH v10 05/12] floppy: move cmos_get_fd_drive_type() from pc,
Gerd Hoffmann <=
- Re: [PATCH v10 00/12] acpi: i386 tweaks, no-reply, 2020/06/19