[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device |
Date: |
Fri, 19 Jun 2020 11:29:24 +0200 |
Hi,
> > Hmm, I guess feeding silence into jack needs some cpu cycles?
> > Maybe add a timer to close the jack server connection? Keep the
> > connection open for re-use for a while, but in case the guest stops
> > playing sound altogether close the jack connection after being unused
> > for a few minutes?
> >
> > [ Doesn't render the patch invalid, consider it a suggestion for future
> > improvements ]
>
> Thanks, I had considered that however there is a usability issue to
> consider. Each time a jack client registers, it removes the client entirely
> and disconnects any custom plumbing that may have been done by the user.
Hmm, ok, that is bad indeed.
Can you stop the stream without closing the connection?
> JACK does not remember this custom routing and as such it's lost until the
> user re-establishes it, or they have some automation set up to do it. While
> this could likely be worked around, it would likely cause more headaches
> then the few CPU cycles lost in a memset.
I'm more concerned about the frequent wakeups to feed the next chunk of
(silence) data to jack.
take care,
Gerd
- [PATCH 0/6] audio/jack: fixes to overall jack behaviour, Geoffrey McRae, 2020/06/11
- [PATCH 0/6] audio/jack: fixes to overall jack behaviour, Geoffrey McRae, 2020/06/14
- [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/14
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/17
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/17
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device,
Gerd Hoffmann <=
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/21
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Gerd Hoffmann, 2020/06/22
- Re: [PATCH 5/6] audio/jack: honour the enable state of the audio device, Geoffrey McRae, 2020/06/22
[PATCH 2/6] audio/jack: remove unused stopped state, Geoffrey McRae, 2020/06/14
[PATCH 4/6] audio/jack: do not remove ports when finishing, Geoffrey McRae, 2020/06/14
[PATCH 1/6] audio/jack: fix invalid minimum buffer size check, Geoffrey McRae, 2020/06/14
[PATCH 6/6] audio/jack: simplify the re-init code path, Geoffrey McRae, 2020/06/14
[PATCH 3/6] audio/jack: remove invalid set of input support bool, Geoffrey McRae, 2020/06/14
Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour, no-reply, 2020/06/14